From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mav.lukeshu.com (mav.lukeshu.com [IPv6:2001:19f0:5c00:8069:5400:ff:fe26:6a86]) by sourceware.org (Postfix) with ESMTPS id 646B23858D37; Mon, 10 Jun 2024 03:09:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 646B23858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lukeshu.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lukeshu.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 646B23858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:19f0:5c00:8069:5400:ff:fe26:6a86 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717988967; cv=none; b=FYHRQ5CWSFUKIgB6nidKemqGaWsfs2Jl0gdHlsag1wAa2JUaljatBZasH4F6EcPkdLZIYBfjFTEDiC0kkHmcFsNJI3b6Zv4uERi3OUQKQaO+HpeCA65d85KR6ao7HqUeU3YfR8Kg3oeFmy9oAH/ALFKzG0EJ9GeurV9FSJnVRd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717988967; c=relaxed/simple; bh=lOAJrdisp33L81U1HLyDOe7vDz2lvhIHwYNwcZWnGeo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Qfd21vrl3HRTPOn7TdqpVJ/6ldtNZnNx/7nLfkbnWeprT9FGCGHGCk7MKqOjimHYDkXLvQyMOmIPUoAGsB1K5jkaoBSpw0wBuI7RSqwv7nXV3NSqAMqII4DD/0Dz/zB3OSF3AlmtsvXkAzAUgVhOj0W+nGyZT8LGiD+4kzyWMzo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from lukeshu-thinkpad-e15 (unknown [IPv6:2601:280:5e01:2a5d:aee0:10ff:fe55:8023]) by mav.lukeshu.com (Postfix) with ESMTPSA id 19AD58067E; Sun, 9 Jun 2024 23:09:23 -0400 (EDT) From: "Luke T. Shumaker" To: binutils@sourceware.org, gdb-patches@sourceware.org Cc: "Ralf Wildenhues" , "Alfred M. Szmidt" , "Tom Tromey" , "Maciej W. Rozycki" , Jan Beulich , Joseph Myers , "Luke T. Shumaker" Subject: [PATCH v2 3/5] zlib: Remove files that should certainly not be checked in Date: Sun, 9 Jun 2024 21:08:31 -0600 Message-ID: <20240610030833.472301-4-lukeshu@lukeshu.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240606201145.1747021-1-lukeshu@lukeshu.com> References: <20240606201145.1747021-1-lukeshu@lukeshu.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LOTSOFHASH,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The *.obj files are compiled binaries that should have been .gitignore'd (and so also add an `*.obj` entry to .gitignore). zlib/example.c and zlib/minigzip.c are outdated duplicates of zlib/test/example.c and zlib/test/minigzip.c My justification believing that the *.obj files should be removed and ignored is as follows: - AFAICT, these files are not used by binutils-gdb. - As shown in the final commit of this patch series, the zlib directory is perfectly re-created *except for these files* by extracting zlib-1.2.12.tar over zlib-1.2.10.tar. Neither of those tarballs include any .obj files. - These files were first added to binutils-gdb.git from gcc.git in 5ca28f79288 (Import zlib from GCC, H.J. Lu, 2015-03-13), which is is a faithful (except for some $Id$ mangling) of zlib-1.2.7.tar. That tarball does not include any .obj files either. - However, zlib tarballs did include some .obj files in the v1.2.[0-3] range. - And whadayaknow, the .obj files were first added to gcc.git in 303ae446cf2a (Initial revision, Tom Tromey, 2005-09-12), which bundled zlib-1.2.1.tar (which as I just said is indeed one of the archives that includes .obj files). - Ever since being first checked in to gcc.git/binutils-gdb.git, the .obj files have never once been updated, even though the associated assembly source code has had substantial revisions. --- v2: - Add *.obj to .gitignore. - Add justification for my beliefs to the commit message. --- .gitignore | 1 + zlib/contrib/masmx64/gvmat64.obj | Bin 4119 -> 0 bytes zlib/contrib/masmx64/inffasx64.obj | Bin 5913 -> 0 bytes zlib/contrib/masmx86/gvmat32.obj | Bin 10241 -> 0 bytes zlib/contrib/masmx86/inffas32.obj | Bin 14893 -> 0 bytes zlib/example.c | 565 ----------------------------- zlib/minigzip.c | 440 ---------------------- 7 files changed, 1 insertion(+), 1005 deletions(-) delete mode 100644 zlib/contrib/masmx64/gvmat64.obj delete mode 100644 zlib/contrib/masmx64/inffasx64.obj delete mode 100644 zlib/contrib/masmx86/gvmat32.obj delete mode 100644 zlib/contrib/masmx86/inffas32.obj delete mode 100644 zlib/example.c delete mode 100644 zlib/minigzip.c diff --git a/.gitignore b/.gitignore index 0a40764c958..ae229bc574e 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,7 @@ *.la *.lo *.o +*.obj *.pyc *.tmp *.a diff --git a/zlib/contrib/masmx64/gvmat64.obj b/zlib/contrib/masmx64/gvmat64.obj deleted file mode 100644 index a49ca029c63e24f907d7cd5d6eaa25f016c9aea5..0000000000000000000000000000000000000000 diff --git a/zlib/contrib/masmx64/inffasx64.obj b/zlib/contrib/masmx64/inffasx64.obj deleted file mode 100644 index 8df5d82616098e1f791526c3cd9875b24f5ad8c0..0000000000000000000000000000000000000000 diff --git a/zlib/contrib/masmx86/gvmat32.obj b/zlib/contrib/masmx86/gvmat32.obj deleted file mode 100644 index ebb326238aed552f381eacbfa69f9ed48d3eb1a3..0000000000000000000000000000000000000000 diff --git a/zlib/contrib/masmx86/inffas32.obj b/zlib/contrib/masmx86/inffas32.obj deleted file mode 100644 index bd6664d111d573b4aa7a4d4a182d33b90d705700..0000000000000000000000000000000000000000 diff --git a/zlib/example.c b/zlib/example.c deleted file mode 100644 index e30389750b2..00000000000 diff --git a/zlib/minigzip.c b/zlib/minigzip.c deleted file mode 100644 index 7aa1c0f4ddd..00000000000 -- 2.45.1