From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 131773882053 for ; Thu, 13 Jun 2024 15:11:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 131773882053 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 131773882053 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718291521; cv=none; b=IdwjOAxOw3MaGaoFjelHk/Uhqv9qe5BZlmNvVPBZB9kQ/OelAap14iJknJvAXzGJvkFQWmjAAOyFSMYYpvXlmi+WS5PJzyIK6lS9EfQesGBhLXW2T29OgOE4FFAdgzU5rn4kqekwpC6HmfwsjWbYNuXa5fyLfHtJzBp3I6SUW7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718291521; c=relaxed/simple; bh=JcM2kcI0AQe3qBMjRTQy/OM2QO084g/d7bcvdfqp13A=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=x4B+aD8mUiveKggxUaCpjTq8ppeJ4yD6COpRdP3zAzLv6txwRydFMKB0bO/tj6z1PGypWKFvHntOim/hQi1qO4ZYkknsQNEzr3LhM7W08dhLqH6qu9LHBWceW8nspZWJHYTy3KgVRX5hrLgIRDsWDHWIoG+RttyoItd/iIV/Vig= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D4C045D4E0 for ; Thu, 13 Jun 2024 15:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718291517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=n6YCB8L2aSuY5uyRr1U8G89ic3u4SLKfpx8Hut2TqlU=; b=PRDQ7FS/fVNazIMubr5p8JAC9FYUCzmf2lZLhzVM/PP30qK3woGA+yttoPoWktdbt/+sky W/NwmglI1+ST/abr9cgppEQboFitPGCUw4K6203V5Lneeb11M2BG1MEzwTPUsXpCaV+Z5x MYB5oXQtv9HI/yMD0PcWVqb7bPL1mlY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718291517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=n6YCB8L2aSuY5uyRr1U8G89ic3u4SLKfpx8Hut2TqlU=; b=banh1n8rOgvhcjEMgzRwdsZxw4IcV3929OPdOXs9AYCPuc3le1uK0G0n7pqW4TXanKHioe JbISuhwCs5jY5NCw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718291517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=n6YCB8L2aSuY5uyRr1U8G89ic3u4SLKfpx8Hut2TqlU=; b=PRDQ7FS/fVNazIMubr5p8JAC9FYUCzmf2lZLhzVM/PP30qK3woGA+yttoPoWktdbt/+sky W/NwmglI1+ST/abr9cgppEQboFitPGCUw4K6203V5Lneeb11M2BG1MEzwTPUsXpCaV+Z5x MYB5oXQtv9HI/yMD0PcWVqb7bPL1mlY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718291517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=n6YCB8L2aSuY5uyRr1U8G89ic3u4SLKfpx8Hut2TqlU=; b=banh1n8rOgvhcjEMgzRwdsZxw4IcV3929OPdOXs9AYCPuc3le1uK0G0n7pqW4TXanKHioe JbISuhwCs5jY5NCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BAFEB13A87 for ; Thu, 13 Jun 2024 15:11:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vg+3Kz0Ma2ZUXQAAD6G6ig (envelope-from ) for ; Thu, 13 Jun 2024 15:11:57 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 1/5] [gdb/testsuite] Clean up gdb/contrib/expect-read1.sh Date: Thu, 13 Jun 2024 17:12:37 +0200 Message-Id: <20240613151241.8144-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.80 X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Clean up script gdb/contrib/expect-read1.sh by: - fixing shellcheck warnings, - using mktemp (which takes TMPDIR into account) instead of a hardcoded "/tmp/expect-read1.$$.so", - adding comments, and - adding emacs / vi settings for local tab size 2 (copied from ./ltmain.sh). Tested on x86_64-linux. --- gdb/contrib/expect-read1.sh | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/gdb/contrib/expect-read1.sh b/gdb/contrib/expect-read1.sh index 890a1cdbd07..82c638c59d2 100755 --- a/gdb/contrib/expect-read1.sh +++ b/gdb/contrib/expect-read1.sh @@ -26,17 +26,32 @@ # or # bash$ EXPECT=../contrib/expect-read1.sh runtest -C=`echo $0|sed 's/\.sh$/.c/'` -if ! test -e $C; then +# Find source file. +C=$(echo "$0" | sed 's/\.sh$/.c/') +if ! test -e "$C"; then echo >&2 "$0: Cannot find 'srcdir/gdb/contrib/expect-read1.c' at '$C'." exit 2 fi -SO=/tmp/expect-read1.$$.so -rm -f $SO + +# Create temp directory. +tmpdir=$(mktemp -d) + +# Schedule cleanup. +trap 'rm -rf $tmpdir' EXIT + +# Compile shared library. +SO=$tmpdir/expect-read1.so CMD="${CC_FOR_TARGET:-gcc} -o $SO -Wall -fPIC -shared $C" if ! $CMD; then echo >&2 "$0: Failed: $CMD" exit 2 fi -trap "rm -f $SO" EXIT + +# Call expect with the shared library preloaded. LD_PRELOAD=$SO expect "$@" + +# Local Variables: +# mode:shell-script +# sh-indentation:2 +# End: +# vi:sw=2 base-commit: 888ff82e77d9ab8f04893a68cd6b4f518d6b50d9 -- 2.35.3