From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 93DBE387093D for ; Wed, 26 Jun 2024 02:02:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93DBE387093D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93DBE387093D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719367344; cv=none; b=mxSeJfCkcXv6cKeNjxGSVj1iMvGoilNJ+5MxSNvda4FNtPk6WcyVuzHbVEJuagE9yjeLHiJnBMVzWLv88HGFi/GJQTMBMj6INIp5kbq+hAl/dZ7VBCg0aYjqqr60W66bCoV2hlVqimeaDfgqaE/Leb7nvUnQW6D5Dx59VKZlRww= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719367344; c=relaxed/simple; bh=UTC3NdfhOfnWd0BkU+1ACt8IOTdSjcGCv/YlwhwkRAs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=g9JkrCRWx0MA0QkixyuO+p0grwNdbRcNGqwRQZxSvRFBry7WSd+ght7/snNJL8bbNL4Dm6k984ulB1bdRO6mBfpHfn/aVmJEwv7JHtdep+px5/P/V5RU1iUyc7S0k3vVwC1RB5JQcGPcl069gqumYIC6udn6Ij4crKclcqXR9RU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719367341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=apwNH8hHeUcxzF7RTGR1OWEZ5qC4OYUAGtvC3WvamBs=; b=SCMqQB247wycHY3gyR3yF4G/ZmjPGMhlstGdilPC/FC+pzT5cE8ZBF1b3RQaC2S4+trU+h /rHEfx4jgevIUdNGSwrgJyZXOKJQPCj3gx3ahvzKBXhYnZzLIWqLT+rbiSkxTSCn+jpeO9 XukiTOHOdHLEoqETqhjg5dIV/h5mNRM= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-6OuDGuBhMXyRDLObZCOl9w-1; Tue, 25 Jun 2024 22:02:19 -0400 X-MC-Unique: 6OuDGuBhMXyRDLObZCOl9w-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B49B919560B3; Wed, 26 Jun 2024 02:02:18 +0000 (UTC) Received: from f40-1.lan (unknown [10.22.16.241]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A7CBC19560AB; Wed, 26 Jun 2024 02:02:17 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Pedro Alves , Kevin Buettner Subject: [PATCH v4 2/4] Capitalize output of successful checkpoint command Date: Tue, 25 Jun 2024 18:55:53 -0700 Message-ID: <20240626020148.68109-3-kevinb@redhat.com> In-Reply-To: <20240626020148.68109-1-kevinb@redhat.com> References: <20240626020148.68109-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This commit causes the output of a "checkpoint" command to be changed from: checkpoint N: fork returned pid DDDD to: Checkpoint N: fork returned pid DDDD This change was made to bring the output of the "checkpoint" command in line with that of other commands, e.g.: (gdb) break main Breakpoint 1 at ... (gdb) catch exec Catchpoint 2 (exec) (gdb) add-inferior [New inferior 2] Added inferior 2 The tests gdb.base/checkpoint.exp, gdb.base/kill-during-detach.exp, and gdb.multi/checkpoint-multi.exp have been updated to accept the new (capitalized) output from the "checkpoint" command. --- gdb/linux-fork.c | 2 +- gdb/testsuite/gdb.base/checkpoint.exp | 2 +- gdb/testsuite/gdb.base/kill-during-detach.exp | 2 +- gdb/testsuite/gdb.multi/checkpoint-multi.exp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c index 833778bf9f7..4905d4ffd88 100644 --- a/gdb/linux-fork.c +++ b/gdb/linux-fork.c @@ -929,7 +929,7 @@ checkpoint_command (const char *args, int from_tty) { int parent_pid; - gdb_printf (_("checkpoint %s: fork returned pid %ld.\n"), + gdb_printf (_("Checkpoint %s: fork returned pid %ld.\n"), (forks_exist_in_multiple_inferiors_p () ? string_printf ("%d.%d", inf->num, fp->num).c_str () : string_printf ("%d", fp->num).c_str ()), diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp index b9a1e3161db..0662fe1c654 100644 --- a/gdb/testsuite/gdb.base/checkpoint.exp +++ b/gdb/testsuite/gdb.base/checkpoint.exp @@ -345,7 +345,7 @@ with_test_prefix "delete checkpoint 0" { clean_restart $binfile runto_main - gdb_test "checkpoint" "checkpoint 1: fork returned pid $decimal\\." + gdb_test "checkpoint" "Checkpoint 1: fork returned pid $decimal\\." gdb_test "restart 1" "Switching to .*" gdb_test "delete checkpoint 0" "Killed process $decimal" gdb_test "info checkpoints" [string_to_regexp "No checkpoints."] diff --git a/gdb/testsuite/gdb.base/kill-during-detach.exp b/gdb/testsuite/gdb.base/kill-during-detach.exp index 68292cc3c51..d9ab8ee5383 100644 --- a/gdb/testsuite/gdb.base/kill-during-detach.exp +++ b/gdb/testsuite/gdb.base/kill-during-detach.exp @@ -93,7 +93,7 @@ proc run_test { exit_p checkpoint_p } { # Set the checkpoint. gdb_test "checkpoint" \ - "checkpoint 1: fork returned pid $::decimal\\." + "Checkpoint 1: fork returned pid $::decimal\\." } # Must get the PID before we resume the inferior. diff --git a/gdb/testsuite/gdb.multi/checkpoint-multi.exp b/gdb/testsuite/gdb.multi/checkpoint-multi.exp index ec999c078c8..a8f0190747b 100644 --- a/gdb/testsuite/gdb.multi/checkpoint-multi.exp +++ b/gdb/testsuite/gdb.multi/checkpoint-multi.exp @@ -23,7 +23,7 @@ require {istarget "*-*-linux*"} require gdb_protocol_is_native set proc_re "(?:process $::decimal|Thread $::hex \\(LWP $::decimal\\))" -set ckpt_re "checkpoint" +set ckpt_re "Checkpoint" set main_proc "\\(main process\\)" set hello_c "hello\\.c" set goodbye_c "goodbye\\.c" -- 2.45.2