From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Fix a data race with the background DWARF reader
Date: Wed, 23 Oct 2024 15:30:43 -0700 [thread overview]
Message-ID: <20241023152907.43bd62b0@f40-zbm-amd> (raw)
In-Reply-To: <20241017-fix-race-pr-symtab-31626-v1-0-3a53459e9651@tromey.com>
On Thu, 17 Oct 2024 18:02:36 -0600
Tom Tromey <tom@tromey.com> wrote:
> This series fixes a race in the background DWARF reader.
>
> I was able to reproduce the original race manually (though not via
> dejagnu), and then confirmed (at least, there weren't warnings from
> TSAN) that this series fixes the problem.
>
> ---
> Tom Tromey (2):
> Use gdb_bfd_get_full_section_contents in auto-load.c
> Add locking when reading BFD sections
>
> gdb/auto-load.c | 11 ++++-------
> gdb/gdb_bfd.c | 23 +++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 7 deletions(-)
> ---
> base-commit: 876f0e78ba8244aa5705530fd8522928f05e6783
> change-id: 20241017-fix-race-pr-symtab-31626-e88148cf55a2
>
> Best regards,
> --
> Tom Tromey <tom@tromey.com>
>
Both patches LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2024-10-23 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 0:02 Tom Tromey
2024-10-18 0:02 ` [PATCH 1/2] Use gdb_bfd_get_full_section_contents in auto-load.c Tom Tromey
2024-10-18 0:02 ` [PATCH 2/2] Add locking when reading BFD sections Tom Tromey
2024-10-23 22:30 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023152907.43bd62b0@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).