From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [pushed 2/2] gdbserver: remove unused include in gdbthread.h
Date: Mon, 28 Oct 2024 14:01:10 -0400 [thread overview]
Message-ID: <20241028180115.115977-2-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20241028180115.115977-1-simon.marchi@polymtl.ca>
clangd reports gdbsupport/common-gdbthread.h as unused in gdbthread.h,
which seems right, so remove it. Add it to two files that need it, but
were relying on the now-removed include.
Change-Id: I12916a044d0b15f346c4ad0e6527ce99a6d460e4
---
gdbserver/gdbthread.h | 1 -
gdbserver/inferiors.cc | 1 +
gdbserver/remote-utils.cc | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdbserver/gdbthread.h b/gdbserver/gdbthread.h
index 389bee103c04..0f81a0f68b54 100644
--- a/gdbserver/gdbthread.h
+++ b/gdbserver/gdbthread.h
@@ -19,7 +19,6 @@
#ifndef GDBSERVER_GDBTHREAD_H
#define GDBSERVER_GDBTHREAD_H
-#include "gdbsupport/common-gdbthread.h"
#include "gdbsupport/function-view.h"
#include "inferiors.h"
diff --git a/gdbserver/inferiors.cc b/gdbserver/inferiors.cc
index 5621db377fb1..4245cb8fd9dc 100644
--- a/gdbserver/inferiors.cc
+++ b/gdbserver/inferiors.cc
@@ -18,6 +18,7 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+#include "gdbsupport/common-gdbthread.h"
#include "gdbsupport/common-inferior.h"
#include "gdbthread.h"
#include "dll.h"
diff --git a/gdbserver/remote-utils.cc b/gdbserver/remote-utils.cc
index 5a8eb9ae52ae..98c34e91220c 100644
--- a/gdbserver/remote-utils.cc
+++ b/gdbserver/remote-utils.cc
@@ -24,6 +24,7 @@
#include "tdesc.h"
#include "debug.h"
#include "dll.h"
+#include "gdbsupport/common-gdbthread.h"
#include "gdbsupport/rsp-low.h"
#include "gdbsupport/netstuff.h"
#include "gdbsupport/filestuff.h"
--
2.47.0
prev parent reply other threads:[~2024-10-28 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 18:01 [pushed 1/2] gdbserver: fix formatting " Simon Marchi
2024-10-28 18:01 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028180115.115977-2-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).