From: Guinevere Larsen <guinevere@redhat.com>
To: gdb-patches@sourceware.org
Cc: Guinevere Larsen <guinevere@redhat.com>
Subject: [PATCH] gdb/testsuite: make gdb.reverse/i386-avx-reverse.exp require avx
Date: Mon, 25 Nov 2024 14:57:26 -0300 [thread overview]
Message-ID: <20241125175726.1012519-1-guinevere@redhat.com> (raw)
The test gdb.reverse/i386-avx-reverse.exp was assuming that if the CPU
was like x86, it would have AVX instructions because I didn't know how
to check for AVX instruction support explicitly. This commit updates
that to use the pre-existing TCL proc have_avx.
Also update the commet at the top of the test, since it was a copy of a
different test.
---
gdb/testsuite/gdb.reverse/i386-avx-reverse.exp | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
index 6d8990067f2..cc920d3a2f3 100644
--- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
@@ -16,15 +16,12 @@
# This file is part of the gdb testsuite.
#
-# This test tests some i386 general instructions for reverse execution.
+# This test tests i386 AVX instructions for reverse execution. This
+# is supposed to test all supported instructions eventually.
#
require supports_reverse
-
-if {![istarget "*86*-*linux*"]} {
- verbose "Skipping i386 reverse tests."
- return
-}
+require have_avx
# TODO: this is the case because I used xmm15 all over the test.
# Some parts of the test require xmm15 to validate some code paths, but
--
2.47.0
next reply other threads:[~2024-11-25 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 17:57 Guinevere Larsen [this message]
2024-12-03 16:00 ` Andrew Burgess
2024-12-03 18:18 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125175726.1012519-1-guinevere@redhat.com \
--to=guinevere@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).