From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/2] [gdb/testsuite] Fix DUPLICATE in gdb.arch/pr25124.exp
Date: Fri, 29 Nov 2024 17:09:39 +0100 [thread overview]
Message-ID: <20241129160939.24045-3-tdevries@suse.de> (raw)
In-Reply-To: <20241129160939.24045-1-tdevries@suse.de>
With test-case gdb.arch/pr25124.exp, I run into:
...
PASS: gdb.arch/pr25124.exp: disassemble thumb instruction (1st try)
PASS: gdb.arch/pr25124.exp: disassemble thumb instruction (2nd try)
DUPLICATE: gdb.arch/pr25124.exp: disassemble thumb instruction (2nd try)
...
Fix this by using a comma instead of parentheses.
Tested on arm-linux.
---
gdb/testsuite/gdb.arch/pr25124.exp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.arch/pr25124.exp b/gdb/testsuite/gdb.arch/pr25124.exp
index 3bf08a178ec..26cfc1368a0 100644
--- a/gdb/testsuite/gdb.arch/pr25124.exp
+++ b/gdb/testsuite/gdb.arch/pr25124.exp
@@ -30,7 +30,7 @@ clean_restart $binfile
# Check if the disassemble ouput is correct.
gdb_test "x /i main+8" \
"$hex <main\\+8>:\[ \t\]+bx\[ \t\]+lr" \
- "disassemble thumb instruction (1st try)"
+ "disassemble thumb instruction, 1st try"
# Reload the symbol file to trigger the bug.
gdb_load ${binfile}
@@ -38,4 +38,4 @@ gdb_load ${binfile}
# Check if the disassemble output is the same as above.
gdb_test "x /i main+8" \
"$hex <main\\+8>:\[ \t\]+bx\[ \t\]+lr" \
- "disassemble thumb instruction (2nd try)"
+ "disassemble thumb instruction, 2nd try"
--
2.35.3
next prev parent reply other threads:[~2024-11-29 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 16:09 [PATCH 0/2] [gdb/tdep] Two fixes for gdb.arch/pr25124.exp Tom de Vries
2024-11-29 16:09 ` [PATCH 1/2] [gdb/symtab] Apply workaround for PR gas/31115 a bit more Tom de Vries
2024-12-02 12:09 ` Alexandra Petlanova Hajkova
2024-12-09 17:20 ` Tom de Vries
2024-11-29 16:09 ` Tom de Vries [this message]
2024-12-03 17:34 ` [PATCH 2/2] [gdb/testsuite] Fix DUPLICATE in gdb.arch/pr25124.exp Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129160939.24045-3-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).