From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <research_trasio@irq.a4lg.com>
Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154])
	by sourceware.org (Postfix) with ESMTPS id CB5DB38582A8
	for <gdb-patches@sourceware.org>; Mon, 24 Oct 2022 07:51:04 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB5DB38582A8
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 9A7CF300089;
	Mon, 24 Oct 2022 07:51:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com;
	s=2017s01; t=1666597862;
	bh=GUW4p0YQLnrsZGbZ0WNlXtZXEIit5nulheMqgxQDKQ0=;
	h=Message-ID:Date:Mime-Version:Subject:To:References:From:
	 In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=X2OHH79NH5qAUKGCaz8j1P4Vq+pCy91+VLxLGl0+el2Qe7ovrn0XgnYQCFg8dA5so
	 Db/sCmWzCoTIzfrsDAfGdd0oHuK7mIipeYgrGAaUG15ONHyZ2JG3Y5F78SFgW55eRa
	 wo9rqsfC3KdhBgDRZ5TnmdqsGZn7fJePI5junRLQ=
Message-ID: <2024f524-35e3-cdc6-8098-a220daf30c23@irq.a4lg.com>
Date: Mon, 24 Oct 2022 16:51:00 +0900
Mime-Version: 1.0
Subject: Re: [PATCH] sim, sim/m32c, sim/rl78: Use getopt_long
Content-Language: en-US
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <3b7e769f-b5e9-4049-786f-d00d997f0280@irq.a4lg.com>
 <24e83e920d728237c4efe6f4720643d6fbbf1084.1666113214.git.research_trasio@irq.a4lg.com>
 <87sfjhb0r5.fsf@tromey.com>
From: Tsukasa OI <research_trasio@irq.a4lg.com>
In-Reply-To: <87sfjhb0r5.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 2022/10/22 1:27, Tom Tromey wrote:
>>>>>> Tsukasa OI via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> Because of Binutils/GCC hack, getopt on GNU libc (2.25 or before) is
>> currently unusable on sim, causing a regression on CentOS 7.  Getting rid of
>> include/getopt.h is the best solution to avoid hacking
> 
> I don't think we want to do remove this file.  getopt_long is required
> by a bunch of programs in the tree, and is part of libiberty -- but it's
> not in the traditional getopt.h.
> 
> Using getopt_long seems like an improvement though.

Glibc (2.25 or before; not too old to drop support) includes <getopt.h>
from <unistd.h> but this causes <unistd.h> to include Binutils/GCC's
include/getopt.h.  It means, using the filename "getopt.h" in an include
path (-I) itself is a risk.  The only reason it didn't cause a problem
is most of Binutils/GCC components used getopt_long and
getopt_long_only, not plain getopt.

After I started checking getopt in sim/configure (to reduce build
failure on Clang), it became a problem on sim because some sim files
actually use plain getopt.

c.f. Following thread under binutils
<https://sourceware.org/pipermail/binutils/2022-October/123543.html>

> 
>> but as a short-term
>> solution, this commit replaces calls to getopt to call getopt_long.
> 
> I notice you didn't update sim/ppc... why is that?

Because I simply missed that (I grepped "getopt (" and two occurrences
under sim/ppc uses "getopt(" without space between "getopt" and "(" ).

Thanks for spotting that and I'll fix it soon.

Thanks,
Tsukasa

> If those don't have the problem then perhaps we can just use that
> solution, whatever it is.
> 
> Tom
>