From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 43D173858D32 for ; Mon, 23 Jan 2023 09:36:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43D173858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E970341F5; Mon, 23 Jan 2023 09:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674466603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8NJLKyAy2012YedjxzSvQYF+PVEoUktP29gcczej1ak=; b=rW+39b2OPOVZVfgL7VNbg3O2hQyC6Rwe43f6dG6F3Yc0o/vlAfSUnlEqTaSFfVwfYHggru mChSvYZjTQ+8NmF7Uth5MDaih0iEQQDP14PTsIDLJXHMR/RB6CjKTi6/XHDyt7rTt3hfmC nYPx+/MA/lEwzj5zYZCS/i4Bkwbnq6Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674466603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8NJLKyAy2012YedjxzSvQYF+PVEoUktP29gcczej1ak=; b=2lb7zCFzcxailwtwlT9znAx35Rg7/meJR2QCv0L1h/Zp1Sr3dD7Leo112Wdqo7vzsCZHJ0 1oyGCLu4n8L/1+BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5E665134F5; Mon, 23 Jan 2023 09:36:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9TPHFStVzmMEfQAAMHmgww (envelope-from ); Mon, 23 Jan 2023 09:36:43 +0000 Content-Type: multipart/mixed; boundary="------------frQ5IvE6Yb5ztnkrh0WtOKyo" Message-ID: <2029a6f2-5c42-3122-a0da-75b961d78cac@suse.de> Date: Mon, 23 Jan 2023 10:36:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/4] [gdb/testsuite] Simplify gdb.base/unwind-on-each-insn.exp Content-Language: en-US To: gdb-patches@sourceware.org Cc: Bruno Larsen , Andrew Burgess , Luis Machado References: <20230119104618.15503-1-tdevries@suse.de> <20230119104618.15503-2-tdevries@suse.de> From: Tom de Vries In-Reply-To: <20230119104618.15503-2-tdevries@suse.de> X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------frQ5IvE6Yb5ztnkrh0WtOKyo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/19/23 11:46, Tom de Vries via Gdb-patches wrote: > In test-case gdb.base/unwind-on-each-insn.exp, we try to determine the last > insn in function foo. > > This in it self is fragile, as demonstrated by commit 91836f41e20 ("Powerpc > fix for gdb.base/unwind-on-each-insn.exp"). > > But the purpose of finding the last insn is to stop stepping in foo when > arriving at that last insn. > > There is however no guarantee that: > - the last insn is actually executed, nor > - that the last insn is executed last, nor > - that the last insn is executed once. > > Fix this by simplying the test-case to continue stepping till stepping out of > foo. > I re-read the commit log, found it not clear enough, and decided to make the difference between: - last disassembled insn, and - last insn executed before returning to main. a bit more explicit. Committed as attached. Thanks, - Tom --------------frQ5IvE6Yb5ztnkrh0WtOKyo Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Simplify-gdb.base-unwind-on-each-insn..patch" Content-Disposition: attachment; filename*0="0001-gdb-testsuite-Simplify-gdb.base-unwind-on-each-insn..pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA3NjdlMTVjMDliNDc0ZTBkZTNkOTMyMzkxODcwNmNlZjZhNWE4NDY2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFdlZCwgMTggSmFuIDIwMjMgMTQ6MTI6NDEgKzAxMDAKU3ViamVjdDogW3B1c2hl ZF0gW2dkYi90ZXN0c3VpdGVdIFNpbXBsaWZ5IGdkYi5iYXNlL3Vud2luZC1vbi1lYWNoLWlu c24uZXhwCgpJbiB0ZXN0LWNhc2UgZ2RiLmJhc2UvdW53aW5kLW9uLWVhY2gtaW5zbi5leHAs IHdlIHRyeSB0byBkZXRlcm1pbmUgdGhlIGxhc3QKZGlzYXNzZW1ibGVkIGluc24gaW4gZnVu Y3Rpb24gZm9vLgoKVGhpcyBpbiBpdCBzZWxmIGlzIGZyYWdpbGUsIGFzIGRlbW9uc3RyYXRl ZCBieSBjb21taXQgOTE4MzZmNDFlMjAgKCJQb3dlcnBjCmZpeCBmb3IgZ2RiLmJhc2UvdW53 aW5kLW9uLWVhY2gtaW5zbi5leHAiKS4KClRoZSB1c2Ugb2YgdGhlIGxhc3QgZGlzYXNzZW1i bGVkIGluc24gaW4gdGhlIHRlc3QtY2FzZSBpcyB0byBzdG9wIHN0ZXBwaW5nIGluCmZvbyBv bmNlIHJlYWNoaW5nIGl0LgoKSG93ZXZlciwgdGhlIGludGVudCBpcyB0byBzdG9wIHN0ZXBw aW5nIGp1c3QgYmVmb3JlIHJldHVybmluZyB0byBtYWluLgoKVGhlcmUgaXMgbm8gZ3VhcmFu dGVlIHRoYXQgdGhlIGxhc3QgZGlzYXNzZW1ibGVkIGluc246Ci0gaXMgYWN0dWFsbHkgZXhl Y3V0ZWQKLSBpcyBleGVjdXRlZCBqdXN0IGJlZm9yZSByZXR1cm5pbmcgdG8gbWFpbgotIGlz IGV4ZWN1dGVkIG9ubHkgb25jZS4KCkZpeCB0aGlzIGJ5IHNpbXBseWluZyB0aGUgdGVzdC1j YXNlIHRvIGNvbnRpbnVlIHN0ZXBwaW5nIHRpbGwgc3RlcHBpbmcgb3V0IG9mCmZvby4KClRl c3RlZCBvbiB4ODZfNjQtbGludXguCi0tLQogLi4uL2dkYi5iYXNlL3Vud2luZC1vbi1lYWNo LWluc24uZXhwICAgICAgICAgIHwgNjIgKysrKy0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDExIGluc2VydGlvbnMoKyksIDUxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvdW53aW5kLW9uLWVhY2gtaW5zbi5leHAgYi9nZGIv dGVzdHN1aXRlL2dkYi5iYXNlL3Vud2luZC1vbi1lYWNoLWluc24uZXhwCmluZGV4IGM4NzQ4 ZDVhZTE0Li41ZTgyMmVmZmFmMSAxMDA2NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFz ZS91bndpbmQtb24tZWFjaC1pbnNuLmV4cAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNl L3Vud2luZC1vbi1lYWNoLWluc24uZXhwCkBAIC03Myw1MSArNzMsNiBAQCBzZXQgbWFpbl9m aWQgW2dldF9maWRdCiBnZGJfYnJlYWtwb2ludCAiKmZvbyIKIGdkYl9jb250aW51ZV90b19i cmVha3BvaW50ICJlbnRlciBmb28iCiAKLSMgRmlndXJlIG91dCB0aGUgcmFuZ2Ugb2YgYWRk cmVzc2VzIGNvdmVyZWQgYnkgdGhpcyBmdW5jdGlvbi4KLXNldCBsYXN0X2FkZHJfaW5fZm9v ICIiCi0KLSMgVGhlIGRpc2Fzc2VtYmx5IG9mIGZvbyBvbiBQb3dlclBDIGxvb2tzIGxpa2U6 Ci0jICAgICBEdW1wIG9mIGFzc2VtYmxlciBjb2RlIGZvciBmdW5jdGlvbiBmb286Ci0jICA9 PiAweDAwMDAwMDAwMTAwMDA2ZGMgPCswPjogICAgIHN0ZCAgICAgcjMxLC04KHIxKQotIyAg ICAgMHgwMDAwMDAwMDEwMDAwNmUwIDwrND46ICAgICBzdGR1ICAgIHIxLC00OChyMSkKLSMg ICAgIDB4MDAwMDAwMDAxMDAwMDZlNCA8Kzg+OiAgICAgbXIgICAgICByMzEscjEKLSMgICAg IDB4MDAwMDAwMDAxMDAwMDZlOCA8KzEyPjogICAgbm9wCi0jICAgICAweDAwMDAwMDAwMTAw MDA2ZWMgPCsxNj46ICAgIGFkZGkgICAgcjEscjMxLDQ4Ci0jICAgICAweDAwMDAwMDAwMTAw MDA2ZjAgPCsyMD46ICAgIGxkICAgICAgcjMxLC04KHIxKQotIyAgICAgMHgwMDAwMDAwMDEw MDAwNmY0IDwrMjQ+OiAgICBibHIKLSMgICAgIDB4MDAwMDAwMDAxMDAwMDZmOCA8KzI4Pjog ICAgLmxvbmcgMHgwCi0jICAgICAweDAwMDAwMDAwMTAwMDA2ZmMgPCszMj46ICAgIC5sb25n IDB4MAotIyAgICAgMHgwMDAwMDAwMDEwMDAwNzAwIDwrMzY+OiAgICAubG9uZyAweDEwMDAx ODAKLSMgICAgIEVuZCBvZiBhc3NlbWJsZXIgZHVtcC4KLSMKLSMgVGhlIGxhc3QgaW5zdHJ1 Y3Rpb24gaW4gZnVuY3Rpb24gZm9vIGlzIGJsci4gIE5lZWQgdG8gaWdub3JlIHRoZSAubG9u ZwotIyBlbnRyaWVzIGZvbGxvd2luZyB0aGUgYmxyIGluc3RydWN0aW9uLgotCi1nZGJfdGVz dF9tdWx0aXBsZSAiZGlzYXNzZW1ibGUgZm9vIiAiIiB7Ci0gICAgLXJlICJeZGlzYXNzZW1i bGUgZm9vXHJcbiIgewotCWV4cF9jb250aW51ZQotICAgIH0KLQotICAgIC1yZSAiXkR1bXAg b2YgYXNzZW1ibGVyIGNvZGUgZm9yIGZ1bmN0aW9uIGZvbzpcclxuIiB7Ci0JZXhwX2NvbnRp bnVlCi0gICAgfQotCi0gICAgLXJlICJeLi4uKCRoZXgpIFxbPD4rMC05OlxzXHRcXSpcLmxv bmdcW1xzXHRcXSpcW15cclxuXF0qXHJcbiIgewotCWV4cF9jb250aW51ZQotICAgIH0KLQot ICAgIC1yZSAiXi4uLigkaGV4KSBcW15cclxuXF0rXHJcbiIgewotCXNldCBsYXN0X2FkZHJf aW5fZm9vICRleHBlY3Rfb3V0KDEsc3RyaW5nKQotCWV4cF9jb250aW51ZQotICAgIH0KLQot ICAgIC13cmFwIC1yZSAiXkVuZCBvZiBhc3NlbWJsZXIgZHVtcFxcLiIgewotCWdkYl9hc3Nl cnQgeyAhW3N0cmluZyBlcXVhbCAkbGFzdF9hZGRyX2luX2ZvbyAiIl0gfSBcCi0JICAgICJm b3VuZCBzb21lIGFkZHJlc3NlcyBpbiBmb28iCi0JcGFzcyAkZ2RiX3Rlc3RfbmFtZQotICAg IH0KLX0KLQogIyBSZWNvcmQgdGhlIGN1cnJlbnQgc3RhY2stcG9pbnRlciwgYW5kIHRoZSBm cmFtZSBiYXNlIGFkZHJlc3MuCiBsYXNzaWduIFtnZXRfc3BfYW5kX2ZiYSAiaW4gZm9vIl0g Zm9vX3NwIGZvb19mYmEKIHNldCBmb29fZmlkIFtnZXRfZmlkXQpAQCAtMTU4LDExICsxMTMs NiBAQCBmb3IgeyBzZXQgaV9jb3VudCAxIH0geyB0cnVlIH0geyBpbmNyIGlfY291bnQgfSB7 CiAJIyBNb3ZlIGJhY2sgdG8gdGhlIGlubmVyIG1vc3QgZnJhbWUuCiAJZ2RiX3Rlc3QgImZy YW1lIDAiICIuKiIKIAotCXNldCBwYyBbZ2V0X2hleGFkZWNpbWFsX3ZhbHVlb2YgIlwkcGMi ICIqVU5LTk9XTioiXQotCWlmIHsgJHBjID09ICRsYXN0X2FkZHJfaW5fZm9vIH0gewotCSAg ICBicmVhawotCX0KLQogCWlmIHsgJGlfY291bnQgPiAxMDAgfSB7CiAJICAgICMgV2UgZXhw ZWN0IGEgaGFuZGZ1bCBvZiBpbnN0cnVjdGlvbnMsIGlmIHdlIHJlYWNoIDEwMCwKIAkgICAg IyBzb21ldGhpbmcgaXMgZ29pbmcgd3JvbmcuICBBdm9pZCBhbiBpbmZpbml0ZSBsb29wLgpA QCAtMTcwLDYgKzEyMCwxNiBAQCBmb3IgeyBzZXQgaV9jb3VudCAxIH0geyB0cnVlIH0geyBp bmNyIGlfY291bnQgfSB7CiAJICAgIGJyZWFrCiAJfQogCi0JZ2RiX3Rlc3QgInN0ZXBpIiAi LioiCisJc2V0IGluX2ZvbyAwCisJZ2RiX3Rlc3RfbXVsdGlwbGUgInN0ZXBpIiAiIiB7CisJ ICAgIC1yZSAtd3JhcCAiJGhleCBpbiBmb28gXFwoXFwpIiB7CisJCXNldCBpbl9mb28gMQor CSAgICB9CisJICAgIC1yZSAtd3JhcCAiIiB7fQorCX0KKworCWlmIHsgISAkaW5fZm9vIH0g eworCSAgICBicmVhaworCX0KICAgICB9CiB9CgpiYXNlLWNvbW1pdDogYmMwYzY3OTNmYjQ1 YjQ5MWM2MzI0NjE0Mjk4YTI4ODBhMzRkMzk2NgotLSAKMi4zNS4zCgo= --------------frQ5IvE6Yb5ztnkrh0WtOKyo--