From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 23D7A3858D28 for ; Mon, 24 Apr 2023 19:35:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23D7A3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.170] (unknown [167.248.160.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 663191E0D3; Mon, 24 Apr 2023 15:35:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1682364901; bh=nizf3YfuXzvxtZVVeM8fcw2Qj8k2CVNWipO1z5Bm+QQ=; h=Date:Subject:To:References:From:In-Reply-To:From; b=SR+yn4Cfx/kc3WrSFw1gUDbFJwV5VG0fCKhEz42fyBa2/RlI3Auv9RH3loSy3/guH 7+4jRtq3APF/kcGgGZueK707tYKVV8ILFG+5hJUXEgGr8uOntgEAx5DgcAcGhTTqRP ieW7yoVnNFq6ZfcCg+9mj7y8nAgh042P7rwsDBME= Message-ID: <202a30ec-1579-9919-9051-ff88c6824560@simark.ca> Date: Mon, 24 Apr 2023 15:35:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Use scoped_restore in varobj.c Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20230424182711.726180-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20230424182711.726180-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/24/23 14:27, Tom Tromey via Gdb-patches wrote: > One spot in varobj.c should use scoped_restore to save and restore > input_radix. Note that the current code may fail to restore it on > error, so this patch fixes a latent bug. Thanks, LGTM. Approved-By: Simon Marchi Simon