From: Hannes Domani <ssbssa@yahoo.de>
To: Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 5/7] Close file handle of empty history file
Date: Tue, 26 May 2020 17:42:37 +0000 (UTC) [thread overview]
Message-ID: <2046464962.6655303.1590514957188@mail.yahoo.com> (raw)
In-Reply-To: <CAPTJ0XETBM1YxduGKps=FYFqSKy44azQA3weKiUFij_B1gj-qA@mail.gmail.com>
> Am Dienstag, 26. Mai 2020, 18:38:07 MESZ hat Christian Biesinger <cbiesinger@google.com> Folgendes geschrieben:
>
> On Mon, May 25, 2020 at 1:58 PM Hannes Domani via Gdb-patches
> <gdb-patches@sourceware.org> wrote:
> >
> > Happened while trying to reproduce a gdb.base/gdbinit-history.exp failure:
> > warning: Could not rename C:/gdb/build64/gdb-git/gdb/testsuite/outputs/gdb.base/gdbinit-history/gdbinit-history.gdb_history to C:/gdb/build64/gdb-git/gdb/testsuite/outputs/gdb.base/gdbinit-history/gdbinit-history.gdb_history-gdb5228~: Permission denied
> >
> > I had an empty gdbinit-history.gdb_history-gdb5228~ file, and the file
> > handle was not closed on startup, so it couldn't rename it at the end
> > when trying to write a new one.
>
> Readline has an upstream repository, please send the patch to them as
> well at bug-readline@gnu.org.
> https://tiswww.case.edu/php/chet/readline/rltop.html
>
> Also add the change to readline/README per the instructions in there.
> Not sure if ChangeLog needs/should be updated.
Apparently, this was already fixed in readline master:
http://git.savannah.gnu.org/cgit/readline.git/commit/?id=f585708e822e021e15e5bece1de482b63ba581df
In that case I don't mind just leaving it as is, since it will be fixed
eventually anyways with the next update.
Hannes
next prev parent reply other threads:[~2020-05-26 17:42 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200525185659.59346-1-ssbssa.ref@yahoo.de>
2020-05-25 18:56 ` Windows testsuite failures Hannes Domani
2020-05-25 18:56 ` [PATCH 1/7] Fix function argument and return value locations Hannes Domani
2020-05-25 21:02 ` Simon Marchi
2020-05-25 21:32 ` Hannes Domani
2020-05-25 22:14 ` Simon Marchi
2020-05-25 23:03 ` Hannes Domani
2020-05-26 16:14 ` Simon Marchi
2020-05-26 20:43 ` Tom Tromey
2020-05-25 18:56 ` [PATCH 2/7] Handle Windows drives in auto-load script paths Hannes Domani
2020-05-26 16:04 ` Jon Turney
2020-05-26 16:31 ` Hannes Domani
2020-05-26 16:05 ` Christian Biesinger
2020-05-26 16:25 ` Hannes Domani
2020-05-26 16:31 ` Christian Biesinger
2020-05-26 16:40 ` Hannes Domani
2020-05-26 16:42 ` Christian Biesinger
2020-05-26 17:14 ` Hannes Domani
2020-05-25 18:56 ` [PATCH 3/7] Handle Windows drives in rbreak paths Hannes Domani
2020-05-25 18:56 ` [PATCH 4/7] Use errno value of first openp failure Hannes Domani
2020-05-26 20:37 ` Tom Tromey
2020-05-25 18:56 ` [PATCH 5/7] Close file handle of empty history file Hannes Domani
2020-05-26 16:37 ` Christian Biesinger
2020-05-26 17:42 ` Hannes Domani [this message]
2020-05-27 14:33 ` Tom Tromey
2020-05-27 17:37 ` Hannes Domani
2020-05-27 18:27 ` Christian Biesinger
2020-05-25 18:56 ` [PATCH 6/7] Move exit_status_set_internal_vars out of GLOBAL_CURDIR Hannes Domani
2020-05-26 20:45 ` Tom Tromey
2020-05-27 17:50 ` Hannes Domani
2020-05-25 18:56 ` [PATCH 7/7] Reset Windows hardware breakpoints on executable's entry point Hannes Domani
2020-05-27 12:07 ` Pedro Alves
2020-05-27 14:48 ` Pedro Alves
2020-05-27 15:39 ` Hannes Domani
2020-05-31 15:54 ` Pedro Alves
2020-05-31 16:37 ` Pedro Alves
2020-06-07 12:56 ` Hannes Domani
2020-07-08 17:43 ` Hannes Domani
2020-10-09 18:22 ` Pedro Alves
2020-10-09 18:51 ` Hannes Domani
2020-10-12 11:13 ` Pedro Alves
2020-10-12 17:21 ` Tom Tromey
2020-10-12 17:22 ` Tom Tromey
2020-05-28 18:15 ` Windows testsuite failures Christian Biesinger
2020-05-28 18:37 ` Hannes Domani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2046464962.6655303.1590514957188@mail.yahoo.com \
--to=ssbssa@yahoo.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).