From: Simon Marchi <simon.marchi@polymtl.ca>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Small cleanups in auxv.c
Date: Thu, 29 Sep 2022 19:57:30 -0400 [thread overview]
Message-ID: <2051296e-6fc7-0b10-e1f8-e781180b15d2@polymtl.ca> (raw)
In-Reply-To: <7670d26b-51de-ccc7-742d-096599759e07@FreeBSD.org>
On 2022-09-29 17:31, John Baldwin wrote:
> On 9/29/22 1:43 PM, Simon Marchi via Gdb-patches wrote:
>> I'm currently reviewing an auxv-related patch, and found these little
>> cleanups could be done.
>>
>> Simon Marchi (3):
>> gdb: constify auxv parse functions
>> gdb: make fprint_target_auxv static
>> gdb: make target_auxv_parse static and rename
>>
>> gdb/auxv.c | 38 +++++++++++++++++++++-----------------
>> gdb/auxv.h | 18 ++++--------------
>> gdb/gdbarch-components.py | 4 ++--
>> gdb/gdbarch-gen.h | 4 ++--
>> gdb/gdbarch.c | 2 +-
>> gdb/ppc-linux-nat.c | 10 +++++-----
>> gdb/s390-linux-nat.c | 10 +++++-----
>> gdb/target-debug.h | 2 +-
>> gdb/target-delegates.c | 14 +++++++-------
>> gdb/target.h | 4 ++--
>> 10 files changed, 50 insertions(+), 56 deletions(-)
>>
>>
>> base-commit: 31282a849107d95d3cfe115ba160f976dd99844c
>
> These all look fine to me.
>
Thanks, pushed.
Simon
prev parent reply other threads:[~2022-09-29 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 20:43 Simon Marchi
2022-09-29 20:43 ` [PATCH 1/3] gdb: constify auxv parse functions Simon Marchi
2022-09-29 20:43 ` [PATCH 2/3] gdb: make fprint_target_auxv static Simon Marchi
2022-09-29 20:43 ` [PATCH 3/3] gdb: make target_auxv_parse static and rename Simon Marchi
2022-09-29 21:31 ` [PATCH 0/3] Small cleanups in auxv.c John Baldwin
2022-09-29 23:57 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2051296e-6fc7-0b10-e1f8-e781180b15d2@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).