From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DB7EB3858CDB for ; Thu, 29 Sep 2022 23:57:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB7EB3858CDB Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 28TNvVKJ021942 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Sep 2022 19:57:35 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 28TNvVKJ021942 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 193221E0D3; Thu, 29 Sep 2022 19:57:31 -0400 (EDT) Message-ID: <2051296e-6fc7-0b10-e1f8-e781180b15d2@polymtl.ca> Date: Thu, 29 Sep 2022 19:57:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 0/3] Small cleanups in auxv.c Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org References: <20220929204354.751741-1-simon.marchi@polymtl.ca> <7670d26b-51de-ccc7-742d-096599759e07@FreeBSD.org> From: Simon Marchi In-Reply-To: <7670d26b-51de-ccc7-742d-096599759e07@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 29 Sep 2022 23:57:31 +0000 X-Spam-Status: No, score=-3033.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2022 23:57:40 -0000 On 2022-09-29 17:31, John Baldwin wrote: > On 9/29/22 1:43 PM, Simon Marchi via Gdb-patches wrote: >> I'm currently reviewing an auxv-related patch, and found these little >> cleanups could be done. >> >> Simon Marchi (3): >>    gdb: constify auxv parse functions >>    gdb: make fprint_target_auxv static >>    gdb: make target_auxv_parse static and rename >> >>   gdb/auxv.c                | 38 +++++++++++++++++++++----------------- >>   gdb/auxv.h                | 18 ++++-------------- >>   gdb/gdbarch-components.py |  4 ++-- >>   gdb/gdbarch-gen.h         |  4 ++-- >>   gdb/gdbarch.c             |  2 +- >>   gdb/ppc-linux-nat.c       | 10 +++++----- >>   gdb/s390-linux-nat.c      | 10 +++++----- >>   gdb/target-debug.h        |  2 +- >>   gdb/target-delegates.c    | 14 +++++++------- >>   gdb/target.h              |  4 ++-- >>   10 files changed, 50 insertions(+), 56 deletions(-) >> >> >> base-commit: 31282a849107d95d3cfe115ba160f976dd99844c > > These all look fine to me. > Thanks, pushed. Simon