From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2078.outbound.protection.outlook.com [40.107.249.78]) by sourceware.org (Postfix) with ESMTPS id 61D3D3858CDB for ; Mon, 28 Nov 2022 11:51:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 61D3D3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sn0mbqdRGwDe1/IxnbG5L3qC+1zp7WISFp/Q4Eh1GxRgL65wTUoRk9ETQdLGDeorsFamltxqzRV2VBcimT+5zoyODxh2wx2G/jTdmzxusIcAk8yATfwU0P/7MxJrAtM5RkmfOrhgbd7qGUNjCn2X+3jx/168UHioq5dowBRsDr1m1/pPYxGTIOA1lhppRzjWFOclhdBkm1n+EffHiWl4QlIFJzaXY59+6tcz2hJP0iNGzc8SSOkqT3ZliprECRmTflfrY8WZKMjDP1j76biUm29eKF6yM/QMzAZWoK1bHrTPLZBYnDeOh7jVEeh8Q5FYOxpKwSLklB3Yc8n6Eq9euA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gAkSISPbgxOAqCiG0q1SS35Al1GWCMyWFw3B+hfiK24=; b=VAWKjnVfMTLSq0GXC+3bKqpkzKOwd92DgHHmmRssU+c4jCbvGSUcYPxDLeiUXgBByT+ICpqsBbWsPFiPOPPRFTejy9uxu9P5IuBwBuOSDL6MmacEJtfszVlRoVoU0ghToixKDMFeB/t3ui9SfRqUiLvVZdu0orypSexLPbbScVcvK1OpfC/Drt5V4D9tKdKrPoF/TXMaIoESmZX4QkplIIGy7V+1YYQwDbcf8U4L3txRPUKc4ovrWzBQR6EKQFAmGuf52A3A1ascBuYL+iPWM1u5LfJ4TxNGBuVjV2L367S5DodWKNPTO0+HnDzajvSa4I9wX/3Ctl8aVwDT0Zl2uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gAkSISPbgxOAqCiG0q1SS35Al1GWCMyWFw3B+hfiK24=; b=I/W/0dJNDEq3anZ+jBGbdEz1TokAoeXpqRhy1PRSLTh35rCG8sghVqW0/LWaEaZMmbsr87nngdhEtNZpi48CiXcJpA4GyeCa9ZDx2dC0oDT6RMD5ij80s0cQ+VQvIU/0YhbcFtVGB+vONKJADq7FthrmuGXpBYpPTheGI41HIZo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GV2PR08MB9326.eurprd08.prod.outlook.com (2603:10a6:150:d4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.6; Mon, 28 Nov 2022 11:51:32 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::fe5c:b195:a2ad:b19c]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::fe5c:b195:a2ad:b19c%4]) with mapi id 15.20.5880.008; Mon, 28 Nov 2022 11:51:32 +0000 Message-ID: <205c734b-ef38-1b05-3737-81872ff6563d@arm.com> Date: Mon, 28 Nov 2022 11:51:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 1/6] gdbserver: Add asserts in register_size and register_data functions Content-Language: en-US To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20221126020452.1686509-1-thiago.bauermann@linaro.org> <20221126020452.1686509-2-thiago.bauermann@linaro.org> From: Luis Machado In-Reply-To: <20221126020452.1686509-2-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0012.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::7) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GV2PR08MB9326:EE_ X-MS-Office365-Filtering-Correlation-Id: b933e485-cc41-4a7f-42cc-08dad136e48e NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CagzklqlunDQp6EAuxjdpOFzY4cIOfZUbJQZ9kfyd1+wVOjkc7h5PNvvlYscpg7I5Aiftvf3DCY2k1LS8iE5ahzNsBYlCewv2hs9h/4k6btN3ULDXbu4n7STK/ED0CLohIMMNS0Ac9PJgQejf8W86ukcm0jFyJH4XVZ7uue9BTu5OK8D0aQakJTe0R2sjAz0T9mS7701E0BciYXN25m8IseFgObTLs6rhNgVAcVXZUze0Gwa3CC+Bgymq7DJdxM/v/Kcl1nJBu6l98wp19AYIghQHleceAyYM99NlMmG83wQCrK1naaHkZyj3eW7vSTaAofmk+5ZYES8jQQRrBBYPPKdG8/z/XdV7OTHhghB7ncViQE+GikmhO8ogRiO1pZyIk5ZTw/puCriPC8LxZAkSdgLsDLp1U4DQhqLeYroLvyxfFfcGiMTHCuod/WrEwqEt1iXUaY3UcZ9V6PrzyBS5M/Sx/rd4Jsi6MIN8FPndkQ5z8IYPZjG9ND7opuXaWaiBE0rqkQ4RRKCaAKqP0UM7AlE7X2bn65grxBs33iRTYghKYKZs2ssbtCPzG9FmmrCG6QNPmHMDwqldUJFxyZvXGO9dS1VXSuKPgtFDh1PXInhbZVfStI9X0k+iTvJj/y/eMS+3l/5Nlr3fRqFeJXsLGoAEXBRCz96bPAdUqzq3s8P7oooc3mbFqGHZOP6tAe3nu0vbGTtvOKuLv88mHPOoyBNjnW055lvAwsDl0Kl0Ww= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199015)(8676002)(83380400001)(2906002)(6512007)(66946007)(66556008)(66476007)(41300700001)(2616005)(31696002)(86362001)(26005)(186003)(316002)(53546011)(5660300002)(44832011)(36756003)(6506007)(8936002)(478600001)(6486002)(31686004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUpPemgwVU5zdDcxWlRBbGV2b1l1VndiVDVXZHl0NmpiSkpEWThsZG53VWZy?= =?utf-8?B?YVVWSENOMmhjNHB2Q01pekhxQmJacjVzZkh5b0VjMFZkd0VRUURmc05FUW15?= =?utf-8?B?dlVzWUJFcnNSRXNNK0tXWXlkSGxPN3RLdVQ5N3gzMzVTeVY2VUFxK1k0SGg4?= =?utf-8?B?alRmQUFUc2VOa3NLelloa29ZdnVRbElybkNuUVhoWUVDckN3a2pyUE10c3Uy?= =?utf-8?B?RmlVdk1vVHlwblRqNmVzZkZKV1ZUK3dLUTA3QnB3OVRrcmk2MDlMVnd6NERP?= =?utf-8?B?aHVRcHRPelVTeWk5ZUQwdm0ya2xQaWdSMkRPN1AwTWMrUVdVSENMWVB4UGo1?= =?utf-8?B?ZElXTUl1ajNnMzBhczdKWklQbmlXbzA0K2tXU3Ard1YrSFo2eVFCQ2hIMjZm?= =?utf-8?B?Q0owL2J6cXV2dlFHYkFPVEptL1luZnVNVDVBMS9XTFRPUCtlbENnNHNVM0cr?= =?utf-8?B?K1h6dHo3NitkY2d6bFpnTHQzakQzckVFNVJ5eTNKQkdWMFQxZHpkTXdmbVRt?= =?utf-8?B?UmsvOTB3NEVneHorT2xPVWlsTXhITC9MeGNHQVYyQTlkTi83b0tmVlg0WXhr?= =?utf-8?B?VFc3dmJwdkJFRmd2dGtzUXcrREVqS3lJcEJUK0RUWDVxZUxjcWZuRzVIRjdS?= =?utf-8?B?TVltakxEUkdxNGtLL2ZweUpSZ1YrVlZrV0Y2UHlqalpXMm5wZWZrNFZERlBa?= =?utf-8?B?U1FGN0I4QWhaQjQvdFg2bzgvR1NIbmhjSHRUMWpySmpGdGNOZXFIa0FyNnUv?= =?utf-8?B?S0Y5WTZ2dlo0RXVtaC9Hb0NNcFdGV1VBaFU0bXVieEtOOUZNWWp5UnNUUzZt?= =?utf-8?B?ai9GcVF4bUU0bC9NcXdTN0d4dDRQdUJaaXZkbWd5eVBuM3lwMVpzK0szbGl6?= =?utf-8?B?dFBrSWdycHZEV1RHSWY4eGRRRHRuMThSVHR2NTdXZlc4bTAwbjBRUVZmNU1G?= =?utf-8?B?MmRweVBtVmhYTlBzbDNYT2JmZURFK2s3dTN2bTdWYXRBOXNPK2pmd2haYU50?= =?utf-8?B?dWRJT3BKK0YyYndsZEhRQ1R2Sm5jYU1BRzdwNnYwU1Yxd3pyaTNnQXlKbDVq?= =?utf-8?B?NzI0cUtaQnlVQnByaGxkc0JkZXBsUW8yWm1BbFRvd3dlU2J3T3hRcGFWZkov?= =?utf-8?B?aGJ4U1dldVB1dzc5ZlNmdTd0WGM1eFF3Y3p1QlFSdEJramY0NE00WVlUTEd6?= =?utf-8?B?Y0s2RDVTNHhuMnZQOHM2NjM2SWZFeStZWklCQkZtMGhUZDRoUVk4NlRyWUk5?= =?utf-8?B?cWZFeWxCTGlyYjhPVzUzVyt4VVhoYjR2TUNSN0YxK0JrNWFSQXpMTGZ5eHhB?= =?utf-8?B?V0k0WjBaY3o2c2Y5M0NJK1ZxSTlwRjdvd0dkWElwZHhrVi9UYWlkblVVQWZC?= =?utf-8?B?QnZBd2RXcVlhTUNSY05EMVUzUC9MQVJ2OGRCSFNnU3VwdXp2UE1pb1NYTDNJ?= =?utf-8?B?Vk9OWDRYS0pIcDJJWUpZMENYZWJ2SDdqUXk0YWlyZEd0MWhxUTZtM1pMMzBF?= =?utf-8?B?ZllFem9KeXlBWXdtN0FqVTFVdERBU0FqSHdOeHB0M3hPQVQ1bmNINU5FUVpX?= =?utf-8?B?cWpWN2JsVXZUY2REaGtYdkNFSzE0WHpNYVpHZDVZTVBvbnZMUVhiTzExdTA0?= =?utf-8?B?TVEzZlpvMmVhZklXNUsxb1AzbmEwSkdhVEk0NExzNXNUQ29HY0FIenJPdFd5?= =?utf-8?B?WFFBZkkrMmcrNkRUMU5hZ1FSK1g3R3UxMzJwM01Oa3dVZ3NBb1V5ZnIxbzJl?= =?utf-8?B?UUtnbTJIU0p1ektIeDJ3UUF4d1hpSWhhamFCNENQNXdFaDhpdXRhZncrZWd5?= =?utf-8?B?SHNxTkV6eDRnd2dIMUI2VlNVWDg2bXBMSWVKR0JjdWViRmVJaWZHWW9QR0Vp?= =?utf-8?B?bGFBdWxYMG9iYUE1NW5LbkpDUVZma0RYZHRsYnB2enUrY1ZhWjUwMnBpdHdK?= =?utf-8?B?OHRXMk4rd1dQd0wraUJIR2YrR0NKV2NETmltWEhCZzRiOEYvVnRKWCticm5F?= =?utf-8?B?aGtLcmsrMnV4TVBwUnlxb0oyOVM2QWJPYU03SmF1dWsraHZXSGdxYlVLOGVI?= =?utf-8?B?WGlwNXJneW9YeWxjcENHYTdvLzdVODRvbVBnUW8xc1lYdml5ejVnT1JUYnpY?= =?utf-8?Q?ZqVrVMcOajli6f1zi1axTmvs8?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: b933e485-cc41-4a7f-42cc-08dad136e48e X-MS-Exchange-CrossTenant-AuthSource: VI1PR08MB3919.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 11:51:32.0407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3xSxbHOF6wR8AUq3uOnXqMbax/5PtR/txRGm5QZ3aHzcR/HQ1QLeUK3pRyYp/Ddckt9PtNuD79doraCFa6C84A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9326 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/26/22 02:04, Thiago Jung Bauermann wrote: > These helped me during development, catching bugs closer to when they > actually happened. > --- > gdbserver/regcache.cc | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc > index 5cbcea978a05..14236069f712 100644 > --- a/gdbserver/regcache.cc > +++ b/gdbserver/regcache.cc > @@ -286,6 +286,8 @@ register_cache_size (const struct target_desc *tdesc) > int > register_size (const struct target_desc *tdesc, int n) > { > + gdb_assert (n >= 0 && n < tdesc->reg_defs.size ()); > + > return find_register_by_number (tdesc, n).size / 8; > } > > @@ -300,6 +302,8 @@ regcache_register_size (const struct regcache *regcache, int n) > static unsigned char * > register_data (const struct regcache *regcache, int n) > { > + gdb_assert(n >= 0 && n < regcache->tdesc->reg_defs.size()); > + > return (regcache->registers > + find_register_by_number (regcache->tdesc, n).offset / 8); > } LGTM. Reviewed-by: Luis Machado