From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 1B8033858D37 for ; Tue, 20 Sep 2022 06:33:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1B8033858D37 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4BFEE1F8B9; Tue, 20 Sep 2022 06:33:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2C73F13ABB; Tue, 20 Sep 2022 06:33:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Kr4ICbpeKWOxMgAAMHmgww (envelope-from ); Tue, 20 Sep 2022 06:33:30 +0000 Message-ID: <206072e6-0e3b-dad8-d75b-e48564f95bf4@suse.de> Date: Tue, 20 Sep 2022 08:33:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: GDB 13 Release 2022-09-11 update Content-Language: en-US To: Tom Tromey Cc: Joel Brobecker , gdb-patches@sourceware.org References: <1983cd06-68ec-e4e1-a2aa-200d016773bf@suse.de> <87a670mfa9.fsf@tromey.com> <876e3b8c-b251-be35-5e4e-c75be25ea0e4@suse.de> <87tu53kktz.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87tu53kktz.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2022 06:33:33 -0000 On 9/20/22 01:26, Tom Tromey wrote: >>> My impression is that .gdb_index never really worked correctly for >>> Ada. > > Tom> Hmm, I committed 7ab96794115 ("[gdb/symtab] Enable ada .gdb_index"). > > Wow, I had completely forgotten about this. > I see I even wrote a corresponding documentation patch. > >>> So, while that is a regression of sorts, since the feature isn't really >>> usable for Ada in general, > > Tom> Um, can you elaborate a bit on why you think that? > > Loss of memory. > > Is there a bug open for this? Yes, https://sourceware.org/bugzilla/show_bug.cgi?id=29179 . > Anyway, I will look at it when I look > into the other issues with the new DWARF reader. > OK. FWIW, I don't mind if we drop this feature if it's difficult to repair or maintain going forward, or too expensive in terms of index size, I'm just trying to make sure that we don't silently regress. > I looked and I can't find my patch to change how .debug_names is > constructed. Hopefully that won't be too hard to rewrite. However, I > did find a patch that I had forgotten about that changes .debug_names so > that it can write out a BFD, solving the string table problem (though I > still didn't write the reader side of this). Hm, interesting. Maybe you could post that patch to some PR? Thanks, - Tom