From: Hannes Domani <ssbssa@yahoo.de>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PING] [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled
Date: Thu, 14 Jan 2021 16:14:48 +0000 (UTC) [thread overview]
Message-ID: <2083445682.3638774.1610640888364@mail.yahoo.com> (raw)
In-Reply-To: <2083445682.3638774.1610640888364.ref@mail.yahoo.com>
Ping.
Am Donnerstag, 31. Dezember 2020, 05:24:32 MEZ hat Simon Marchi <simon.marchi@polymtl.ca> Folgendes geschrieben:
> On 2020-12-29 12:02 p.m., Hannes Domani via Gdb-patches wrote:
> > There seems to be no other way to determine if TUI is enabled, which is a
> > problem in case the TUI is disabled, and you redraw the window contents
> > based on some registered event.
> > Then the TUI is redrawn, even though the TUI stays disabled, and the prompt
> > is anywhere on the screen.
> >
> > gdb/ChangeLog:
> >
> > 2020-12-29 Hannes Domani <ssbssa@yahoo.de>
> >
> > * python/py-tui.c (gdbpy_tui_is_valid): Check tui_active as well.
> > ---
> > gdb/python/py-tui.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gdb/python/py-tui.c b/gdb/python/py-tui.c
> > index 87065eaf60..9c35778bcb 100644
> > --- a/gdb/python/py-tui.c
> > +++ b/gdb/python/py-tui.c
> > @@ -356,7 +356,7 @@ gdbpy_tui_is_valid (PyObject *self, PyObject *args)
> > {
> > gdbpy_tui_window *win = (gdbpy_tui_window *) self;
> >
> > - if (win->window != nullptr)
> > + if (tui_active && win->window != nullptr)
> > Py_RETURN_TRUE;
> > Py_RETURN_FALSE;
>
> > }
> >
>
> I think that makes sense, although I'd like Tom to confirm.
next parent reply other threads:[~2021-01-14 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2083445682.3638774.1610640888364.ref@mail.yahoo.com>
2021-01-14 16:14 ` Hannes Domani [this message]
2021-01-15 16:49 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2083445682.3638774.1610640888364@mail.yahoo.com \
--to=ssbssa@yahoo.de \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).