From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140078.outbound.protection.outlook.com [40.107.14.78]) by sourceware.org (Postfix) with ESMTPS id E54DD3858C56 for ; Thu, 18 Aug 2022 15:43:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E54DD3858C56 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=W+2Y6/fcmlk06Ma4ZPRv5vpwusBOoTi24U0f+3P2GX7StmdKufZufRn+ii7Em1aiH9VDy9xqGucSSALAe+nn90nAnwqK0ysoBOQBjL16MUev2R9BL5p70Q+ozBRxc86na9uap24xCG5f73Lp/9gWaegcd8Vc8sOQX20pU2a76kCFvyKv44a6FYlKlwYW7hXyLiYUiwgbmj9fIqk8U9EVG3AtpIgTv2ZlWpGMNLBOGJL33ikTPnun6UFcdhZTuIiBbxjD2RSivyzIAwZcHgOwpwOfN8LgPa/EKJhiBs75/fXmnj4kQfQvsoHh2SOumPRKC4sCEz+8Swop6aH/f9D17Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9JO56RZrDJBqtO1i2Swulw2nIvUb3ocdU5vqCY49SXw=; b=QeOtShhSo6BLAjmzziDnbQyT+kRfp+vJfoNMEjjwIcvU0hQ4DvYw1wIS+aNgyvzVghQ8eG4Yg4zA29w2uGBCLQyg5EmW5h0aOOoKGUQVwZcvJ+9mbBO+aYg0jf8lqTEMkyueGgMWSHfSbntuIAm/lWxpM61M7tADxLd4Hp5OPwKYLGnLo9avjj7HXHk1UqKcyYXp9p7J9xnewCaBoWsrXBzH4uRN6wHH0sD0dWDSvfaaWjrJ/u6rZS3vJXvhXNIkx5NQpOI/Zvctc9L7O0wEgZ1lOkPnve/Yg7YdKZU5doeIctzU2ixrrSSpwEyKqybFHuZni6KIDimbxFzDSFOTQg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR06CA0141.eurprd06.prod.outlook.com (2603:10a6:20b:467::13) by VI1PR08MB3213.eurprd08.prod.outlook.com (2603:10a6:803:46::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Thu, 18 Aug 2022 15:43:54 +0000 Received: from AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:467:cafe::4d) by AS9PR06CA0141.outlook.office365.com (2603:10a6:20b:467::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.15 via Frontend Transport; Thu, 18 Aug 2022 15:43:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT057.mail.protection.outlook.com (100.127.140.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Thu, 18 Aug 2022 15:43:53 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Thu, 18 Aug 2022 15:43:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 88ed63f5439df02f X-CR-MTA-TID: 64aa7808 Received: from da93e9bc86b8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C94F5CFA-7D44-43CC-9200-7816105BA503.1; Thu, 18 Aug 2022 15:43:46 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id da93e9bc86b8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 18 Aug 2022 15:43:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMN8kNA7KAnR9AS1rHTxbyRbvc/qPI8tJS2JJN7bdPJ2wFVvef3+6DilDvkolTclUt1q93LkwZxIYg8/2dyUobHhzbuuDcqthjRe2Vj4dFu8b2jbkZjmn5wV3keTtdmLNjDj6jvgRUfteE4h0hvNUBQmfkYKHe9zvHicJV2kbU5HpqOxkLCAFt4nPlPlVgVyjYZemD/6q8wciC3RMBmwrl7LgLTQymfrRmE0w3KHQADoCsUVX4EcOjwp8MCFGQEwnyADMPOTXVvfipY5qeF5ipT/+irZABHKRQ+/+QV0l+LNa2ceOBOV19ZAX95I1GID+TH4zrSK0iAjvNVwRJFHng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9JO56RZrDJBqtO1i2Swulw2nIvUb3ocdU5vqCY49SXw=; b=OvTQ6u/qFw6SBNe98MnqAZ5O40zjrXCNL0naq3V3ZQcclMyrTlQ616a3EmJuXvmLxBeiceELmdAM30tKTGrpxEVA0vv+XjzGV6c4ASj4CEzV5kkfHYQCI7gt1KypaQaGjsHjQrChLEKCawePm70kIVPbZpqrzqAa/t+oif209U5EEwY5I+gtlM7X1H5NNnkLUALamXsIywD2gHWzBoNB8nUP4JPH8TyWpny7sTaWGCfjTDofGtywbdwoERwRpxkd/p4YqKoGynpIde52XYDY2mxhu8o1PUOFBM0TWmaIirjlqYZImU+Vxpg7LcbCO6cQ+Mq9JgNbkzeyJaN7M9jF9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB4PR08MB7936.eurprd08.prod.outlook.com (2603:10a6:10:378::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Thu, 18 Aug 2022 15:43:44 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8%4]) with mapi id 15.20.5504.028; Thu, 18 Aug 2022 15:43:43 +0000 Message-ID: <20d0c4aa-a82c-55ca-7d2c-84b0b1f6b01d@arm.com> Date: Thu, 18 Aug 2022 16:43:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] [aarch64] Remove handling of ADR/ADRP from prologue analyzer Content-Language: en-US To: gdb-patches@sourceware.org References: <20220817083334.139191-1-luis.machado@arm.com> From: Luis Machado In-Reply-To: <20220817083334.139191-1-luis.machado@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0051.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::20) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: a19f1948-422d-42a0-5f15-08da81307485 X-MS-TrafficTypeDiagnostic: DB4PR08MB7936:EE_|AM7EUR03FT057:EE_|VI1PR08MB3213:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UsxcbMwjRO4S7OPysy73vsiAQIiFjuy17x/oeGUoWw7vadKmUxR1Yca8jcI800oMpQInvgUMXzzWFutvn0wmMNoFfgaiakTrDKV/kVGkPOBgG3XuhQdsL2DejNGYfdS8VucrjNxOTuQCdjHFTPfojIJpFbKkFRc05PmsPTlkOhtHX8W0lsuzQvgfN+sX5h4b6YPCS63onRrE+t8zN9Wbxc2KZ+6Lmby/pvQr50RzE5IXjzXLOVVD8VD0gOY6mYglakAdxMMzZWZdgsUWmSaHUEMS2d5+XiNqlHwb41VlS0fRu88wutm39mFEmORLl91zRIStqxlVGvKSCNxl2CJtMtoRezvFkGUkYprGiAxOSwBPUztlt+UEPZalTtpA/BgHIv+qDufkaexfCfLJsGq2FbjgsKCigDFfgP1+V+Ut+sk5ejzvtN/ZgUPY30T5VfKczr1XwLcHsUNHv+7/6hcLgrofmyTpDRjXgxp91seO5LNFg5BvgHzEVZz5+xZv0dG4PWyxbteoPyy+YLuO0mbzbhZsDrV/awMwZtrZhSZtXESt30VJd8WUAIquI9f+6Wt7ZFouYZPLlgpaoJvllscL3Zp6N89UoQ8yjomskMXotOBWKEU9MS4zKlMJROj+UsLyfHU4o5KvZkZXWULTZ1U9STaLSCeDMzCs6i9RDspksds+5xMCyo603M2rBsWK/o6q1C26t0suWNZDw/DSAXLLEYHQhjbsHtQ8e+myYcoFCIpttr3KGwzlzM1m90/aHQygu1wVv+KdY2MaUjAQhIGDgZa+d9kt2csLVW8Vy5NySh1PkrYPYlQVJt2OixqKL5u1/vRzYA2oisImdYvIV/XLDUyBFt6PfBywpcHeNSK3+Lg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(136003)(396003)(366004)(39860400002)(36756003)(6916009)(41300700001)(186003)(26005)(31686004)(6512007)(2906002)(8676002)(66476007)(66946007)(316002)(86362001)(31696002)(44832011)(38100700002)(66556008)(2616005)(478600001)(6486002)(53546011)(8936002)(6506007)(5660300002)(83380400001)(966005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB7936 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: db32f00e-e797-4b43-6d9d-08da81306e31 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RWuQ0J4DaGEwlwz5HAoPddPoIb95lhssD8sBmP8fExBImbVKlCNoTWYYlz0J4vM6vkEglcQMYA93jc/AcNDpRyWQopmuTkuZyOPqZQolz0mgnFxka86lIIvzrjwX6u4sYPPMM7g7OIkhcG2ElcCmBqipmMFqoE8qbymDSMH7NlpXGx7ReYepuA8cp3PeGTfk3EAohgJ7cD0r/rYjYTm6L+YHnC9g3TieZM4x4dyR9LLiBYtv4ImYh5plsZ+r1D4F381lNOCEw2XdsYo3FtDnjBJGt2gINAcY3V2qeJzikS/BV/F5wcB/rh4U15gK59Lw3D1uNMf+WB6gunCClqSdmAvXpKR9xfqxmR8PNoBKr4NBHdx4gxtxOHYrh1EJIQSiwhk1/NrmAzLVJLp2EtdnogawbM1w1aKRWvaOWmy819VG17vPX338d/sLyehR/xTSMn8O6neA8RoRrH4veaWszdtEeT5doGOn10b42HXBSnal5nSwT5FwZvL0NDPFM26ZI2WcvuHYpCmXt/J3GbB0Zl9thwfrNR1i+F67Og3euYOZwF0nlX+IZ4CWcS3OESeEV+YwQnMjpLm5YyOQfkNaj7swRz0VancBB5XR4p2mUS3rReCDMcfFzbkkQmC+9mpcJCZn6LxbO362T8QWbEprUoVf+HqHFVVSwu3YMQXTT71Ei17Kg4jzuu+stpgPcKvQPh76eHn92wPjHhAwb0wdNty4U7QIQJmN8NeIdjvPGxI3v8//LinstOlxenHal6son/jrPBtIqfCFhBg2yiQqbRonst58jmJIo57qIWAZWEXP4vp7tkxlydpgrPbzQhTyuiLknTg+jos5wUxdFX/9tfoRo37SSodqrYeKQ6IDa40= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(376002)(396003)(346002)(39860400002)(36840700001)(46966006)(40470700004)(6512007)(26005)(41300700001)(6506007)(36756003)(53546011)(316002)(6486002)(966005)(478600001)(86362001)(2906002)(31696002)(40480700001)(82310400005)(70206006)(70586007)(44832011)(8676002)(40460700003)(8936002)(6916009)(356005)(83380400001)(36860700001)(5660300002)(186003)(47076005)(31686004)(82740400003)(2616005)(336012)(81166007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 15:43:53.9188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a19f1948-422d-42a0-5f15-08da81307485 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3213 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2022 15:43:58 -0000 On 8/17/22 09:33, Luis Machado via Gdb-patches wrote: > As reported by Tom in https://sourceware.org/pipermail/gdb-patches/2022-August/191357.html, > the aarch64 prologue analyzer considers the adrp instruction in the > gdb.dwarf2/dw2-dir-file-name.exp testcase to be part of a prologue. > > The function has no prologue though, and it only loads the volatile variable > from memory. GDB should not skip any instructions in this case. > > Doing some archaeology, it seems handling for adr/adrp in prologues was > included with the original aarch64 port. It might've been an oversight. > > In the particular case of gdb.dwarf2/dw2-dir-file-name.exp, the analyzer skips > a couple instructions and leaves us in a nice spot where the address to the > variable "v" is already in w0. But no prologues exists. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29481 > --- > gdb/aarch64-tdep.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index f747ebda1ab..0385bc18632 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -354,14 +354,6 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch, > > regs[rd] = pv_subtract (regs[rn], regs[rm]); > } > - else if (inst.opcode->iclass == pcreladdr > - && inst.operands[1].type == AARCH64_OPND_ADDR_ADRP) > - { > - gdb_assert (aarch64_num_of_operands (inst.opcode) == 2); > - gdb_assert (inst.operands[0].type == AARCH64_OPND_Rd); > - > - regs[inst.operands[0].reg.regno] = pv_unknown (); > - } > else if (inst.opcode->iclass == branch_imm) > { > /* Stop analysis on branch. */ Pushed now.