From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 321D7385B52B for ; Thu, 15 Dec 2022 14:50:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 321D7385B52B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671115857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qrQXmqm1ips7iCXJODTlml5HCu2Dy+ErEfT1h5MqNzs=; b=DtDzw+OqgcKcWn9hsM6DBw8RDQrSk/KvY9sC5wtCrvlqK6jLaBG7AmLqjrwJzuAmOawUa9 JPQBXhV52fkRj4bXMcJ84r40luZKiEls8xrcnrUEoqBWGODYhNyRLx2nLcV/WM3DlOVwyw B0Wc9aQepqwcf61aGRG/8jKp6DA+w5M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-151-ZvpotSBlOsSUCCm8lKHQsA-1; Thu, 15 Dec 2022 09:50:56 -0500 X-MC-Unique: ZvpotSBlOsSUCCm8lKHQsA-1 Received: by mail-wm1-f69.google.com with SMTP id ay19-20020a05600c1e1300b003cf758f1617so1225071wmb.5 for ; Thu, 15 Dec 2022 06:50:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qrQXmqm1ips7iCXJODTlml5HCu2Dy+ErEfT1h5MqNzs=; b=qL4/8fGBuNVPkINTHs4N7Ag1R+J3+Umyy7lYZ6sy/Myl2Zzhld8hvDLz9DLoyBU+NB b13kA83L+r1ErvxtTwZdYXkkqqnB2QJsASGpxTO6EhdPrCEyb6LvHQVN6eAI+wo1ldaa oomS1vWaDDFSbdhU2A+aEFiKSobwnUZEble1/BzJxIQ7OsAF41tNVubAuW7v8W+OTHh7 q09CoP7j1QG77t8uuYpAHjXM/wW5/KXK4fEfHeaV9goMiK/3OaTjBfO8mn1PHpEFlj3Y KdAaG8LzqE86bcskWSW5nQQehHtH6p0nfm25WCgbmicRHCnrGotiryJngL+MhJ6ireeR +wFA== X-Gm-Message-State: ANoB5plU5OI5FeUMiqvg/FxjADiprYSJIiwV9QvqqxYXqmSIbDvxzxlm PN8ZjVzANP2UUcvZwpNK0GG1Qd8K5+a8lbm7fellzGa8mCFJG9C2v+F/vXxTqmqXiq2IkyMjtpL HOx/vfwBUwr5U9mSQshj2Cg== X-Received: by 2002:a05:6000:1d84:b0:236:3686:797 with SMTP id bk4-20020a0560001d8400b0023636860797mr18034198wrb.65.1671115855637; Thu, 15 Dec 2022 06:50:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Efcgxz+hDD1tKt6wOSNwujs21Ly1Hotdadb/ILnjWJZyCIpi7XlcFZ5+y3l99pgM09f6e5Q== X-Received: by 2002:a05:6000:1d84:b0:236:3686:797 with SMTP id bk4-20020a0560001d8400b0023636860797mr18034190wrb.65.1671115855441; Thu, 15 Dec 2022 06:50:55 -0800 (PST) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id h11-20020a5d688b000000b00241b5af8697sm6144588wru.85.2022.12.15.06.50.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 06:50:55 -0800 (PST) Message-ID: <20ed570d-5d37-123a-ebd2-ff9203504dc9@redhat.com> Date: Thu, 15 Dec 2022 15:50:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: Fwd: [PATCH v3 1/2] gdb/c++: validate 'using' directives based on the current line To: Alexandra Petlanova Hajkova , gdb-patches@sourceware.org References: <20221122113319.1760546-1-blarsen@redhat.com> <20221122113319.1760546-2-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15/12/2022 14:26, Alexandra Petlanova Hajkova via Gdb-patches wrote: > On Tue, Nov 22, 2022 at 12:52 PM Bruno Larsen via Gdb-patches < > gdb-patches@sourceware.org> wrote: > >> >> Finally, because the final test of gdb.cp/nsusing.exp has turned into >> multiple that all would need XFAILs for older GCCs (<= 4.3), and that >> GCC is very old, if it is detected, the test just exits early. >> > I suggest using shorter sentences in general and I think the last sentence > needs > to be split in two. I had to read it 3 times to fully understand it. Hi Sasha, Thanks for the review! I'll try to keep my sentences short in the future. What do you think about changing the last paragraph to: Finally, more tests were added to the end of gdb.cp/nsusing.exp. However, GCC version 4.3 or older already had troubles with the original test. If we detect that one of those old GCCs are used the test will just exit early instead of add many XFAILs. -- Cheers, Bruno