From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7049 invoked by alias); 19 Sep 2013 23:37:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7039 invoked by uid 89); 19 Sep 2013 23:37:14 -0000 Received: from mail-ve0-f202.google.com (HELO mail-ve0-f202.google.com) (209.85.128.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 19 Sep 2013 23:37:14 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,SPF_SOFTFAIL autolearn=ham version=3.3.2 X-HELO: mail-ve0-f202.google.com Received: by mail-ve0-f202.google.com with SMTP id jy13so1099752veb.5 for ; Thu, 19 Sep 2013 16:37:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=hMe9ulcnX7tzI6xu8S5AJv46Z5XNHijONnlnQVfJ3U4=; b=Kx5M962rdsqhoQXpfXuAk7x9TWsxmXaPfTMdkm+WjbtEuN+CXNgFImepjon8yEqKq2 91UDMNTlJYaVqIDG8tvboFXltlJo8AaZf4sXjSx/RBLkzpDwvwXwOcFmpTVCQcukOwb8 woBaDfaa52xEev2LXEowIVEBE6jAg0xyIJOndBPrQrtr2exhUSjRWP19WCGLBooUM2Rh mSQiyxs/TLUT6DbT76W+scJOWEpQVOah3EPij40AxcQGvbN3AABTKl4nM8dMM7L4oroR 02ta4+IAAFNWrNYFcRFTArEO5ee85fGEu1kGAlxCOLk/tbwQ2SWJqM4Qrw6YLPBFc3Ft OYuw== X-Gm-Message-State: ALoCoQlmbwEksQpb/cHY+GZQyqiNRO9aQl8CAU3Ts+JaU5f7l9ZO/LSFYPydRN3EMhIlEmcfGb85n1psD1/GpSoA20OWOUdscbe6YMy9KQ4vE8WTtMmWSALnY/3u7d5veKfMkRXbUVTUy18BTkhDEYivMzCJww5WQVqvLoaOaGBOaewcPgAHjDDw2ZsyRJX9yVuLWzCSSzTVXS/F+fW0IjzwXjFG7yDURA== X-Received: by 10.236.94.39 with SMTP id m27mr48357yhf.54.1379633831218; Thu, 19 Sep 2013 16:37:11 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id y62si1210618yha.0.1969.12.31.16.00.00 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Thu, 19 Sep 2013 16:37:11 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id A8B2C31C20F; Thu, 19 Sep 2013 16:37:10 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21051.35494.124735.388497@ruffy.mtv.corp.google.com> Date: Thu, 19 Sep 2013 23:37:00 -0000 To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patchv4 4/5] Keep objfile original filename In-Reply-To: <20130919135631.GD16978@host2.jankratochvil.net> References: <20130919135631.GD16978@host2.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00711.txt.bz2 Jan Kratochvil writes: > gdb/ > 2013-09-15 Jan Kratochvil > > Pass down original filename for objfile. > * coffread.c (coff_symfile_read): Update symbol_file_add_separate call. > * elfread.c (elf_symfile_read): Likewise. > * jit.c (jit_object_close_impl): Update allocate_objfile call, no > longer set ORIGINAL_NAME. > (jit_bfd_try_read_symtab): Update symbol_file_add_from_bfd call. > * jv-lang.c (get_dynamics_objfile): Update allocate_objfile call. > * machoread.c (macho_add_oso_symfile): Add parameter name. Update > symbol_file_add_from_bfd call. > (macho_symfile_read_all_oso): Update two macho_add_oso_symfile calls. > (macho_check_dsym): Add parameter filenamep. Change function comment. > Set *filenamep. > (macho_symfile_read): New variable dsym_filename. Update > macho_check_dsym call. Use it for symbol_file_add_separate. > * objfiles.c (allocate_objfile): Add parameter name. New comment for > it. Use it for objfile->original_name. > (objfile_name): Return OBFD's filename, if available. > * objfiles.h (allocate_objfile): Add new parameter name. > * solib-sunos.c (allocate_rt_common_objfile): Remove variable name. > Update allocate_objfile call. Remove obstack_copy0 call. > * solib.c (solib_read_symbols): Update symbol_file_add_from_bfd call. > * symfile-mem.c (symbol_file_add_from_memory): Update > symbol_file_add_from_bfd call. > * symfile.c (read_symbols): Update symbol_file_add_separate call, new > comment for it. > (symbol_file_add_with_addrs): New parameter name, add function comment > for it. Remove variable name. Update allocate_objfile call. > (symbol_file_add_separate): New parameter name, add function comment > for it. Update symbol_file_add_with_addrs call. > (symbol_file_add_from_bfd): New parameter name. Update > symbol_file_add_with_addrs call. > (symbol_file_add): Update symbol_file_add_from_bfd call. > (reread_symbols): New variable original_name. Save > objfile->original_name by it. > * symfile.h (symbol_file_add_from_bfd, symbol_file_add_separate): Add > second parameter. LGTM