From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v3 3/9] gdb/jit: split jit_objfile_data in two
Date: Wed, 15 Jul 2020 10:19:27 -0400 [thread overview]
Message-ID: <21062818-ac80-ed65-f4ba-7cddaba3a4a9@polymtl.ca> (raw)
In-Reply-To: <cd928e8a878b4038c7495b7598e138f659333eef.1594799616.git.tankut.baris.aktemur@intel.com>
On 2020-07-15 4:16 a.m., Tankut Baris Aktemur wrote:
> @@ -429,10 +426,20 @@ struct jit_objfile_data
>
> /* Symbol for __jit_debug_descriptor. */
> minimal_symbol *descriptor = nullptr;
> +};
> +
> +/* An objfile that is the product of JIT compilation and was registered
> + using the JIT interface has an instance of this type attached to it. */
> +
> +struct jited_objfile_data
> +{
> + jited_objfile_data (CORE_ADDR addr)
> + : addr (addr)
> + {}
>
> - /* Address of struct jit_code_entry in this objfile. This is only
> + /* Address of struct jit_code_entry for this objfile. This is only
> non-zero for objfiles that represent code created by the JIT. */
> - CORE_ADDR addr = 0;
> + CORE_ADDR addr;
I think the "This is only non-zero..." part of the comment can be removed?
Simon
next prev parent reply other threads:[~2020-07-15 14:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 8:16 [PATCH v3 0/9] Handling multiple JITers Tankut Baris Aktemur
2020-07-15 8:16 ` [PATCH v3 1/9] gdb/jit: pass the jiter objfile as an argument to jit_event_handler Tankut Baris Aktemur
2020-07-15 13:48 ` Simon Marchi
2020-07-21 16:24 ` Aktemur, Tankut Baris
2020-07-15 8:16 ` [PATCH v3 2/9] gdb/jit: link to jit_objfile_data directly from the objfile struct Tankut Baris Aktemur
2020-07-15 14:16 ` Simon Marchi
2020-07-21 16:25 ` Aktemur, Tankut Baris
2020-07-21 17:42 ` Simon Marchi
2020-07-15 8:16 ` [PATCH v3 3/9] gdb/jit: split jit_objfile_data in two Tankut Baris Aktemur
2020-07-15 14:19 ` Simon Marchi [this message]
2020-07-21 16:24 ` Aktemur, Tankut Baris
2020-07-15 8:16 ` [PATCH v3 4/9] gdb/jit: apply some simplifications and assertions Tankut Baris Aktemur
2020-07-15 8:16 ` [PATCH v3 5/9] gdb/jit: move cached_code_address and jit_breakpoint to jiter_objfile_data Tankut Baris Aktemur
2020-07-15 8:16 ` [PATCH v3 6/9] gdb/jit: enable tracking multiple JITer objfiles Tankut Baris Aktemur
2020-07-15 8:16 ` [PATCH v3 7/9] gdb/jit: remove jiter_objfile_data -> objfile back-link Tankut Baris Aktemur
2020-07-15 8:16 ` [PATCH v3 8/9] gdb/jit: apply minor cleanup and modernization Tankut Baris Aktemur
2020-07-15 8:16 ` [PATCH v3 9/9] gdb/jit: skip jit symbol lookup if already detected the symbols don't exist Tankut Baris Aktemur
2020-07-19 15:44 ` [PATCH v3 0/9] Handling multiple JITers Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21062818-ac80-ed65-f4ba-7cddaba3a4a9@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).