From: Doug Evans <dje@google.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch][python] 1/3 Python representation of GDB line tables (Python code)
Date: Fri, 08 Nov 2013 17:08:00 -0000 [thread overview]
Message-ID: <21117.6425.284003.919541@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <527CF370.9030808@redhat.com>
Phil Muldoon writes:
> I've made the requested changes. For the sake of brevity I have just
> included the three file diffs this time around instead of mailing the
> whole series.
>
> This OK?
Thanks.
"works for me"
[I missed a few things in my previous review. Blech. Mea culpa.
There's a couple of function comments that don't have a blank
line between them and their function. How could I have missed that??? :-)
Ok with those changes, no need for another iteration on my account.
Thanks again.
> +/* Deconstructor for the line table object. Decrement the reference
> + to the symbol table object before calling the default free. */
Here.
> +static void
> +ltpy_dealloc (PyObject *self)
> +{
> + linetable_object *obj = (linetable_object *) self;
> +
> + Py_DECREF (obj->symtab);
> + Py_TYPE (self)->tp_free (self);
> +}
> +
> +/* Initialize LineTable, LineTableEntry and LineTableIterator
> + objects. */
Here.
> +int
> +gdbpy_initialize_linetable (void)
> +{
> + if (PyType_Ready (&linetable_object_type) < 0)
> + return -1;
> + if (PyType_Ready (&linetable_entry_object_type) < 0)
> + return -1;
> + if (PyType_Ready (<py_iterator_object_type) < 0)
> + return -1;
> +
> + Py_INCREF (&linetable_object_type);
> + Py_INCREF (&linetable_entry_object_type);
> + Py_INCREF (<py_iterator_object_type);
> +
> + if (gdb_pymodule_addobject (gdb_module, "LineTable",
> + (PyObject *) &linetable_object_type) < 0)
> + return -1;
> +
> + if (gdb_pymodule_addobject (gdb_module, "LineTableEntry",
> + (PyObject *) &linetable_entry_object_type) < 0)
> + return -1;
> +
> + if (gdb_pymodule_addobject (gdb_module, "LineTableIterator",
> + (PyObject *) <py_iterator_object_type) < 0)
> + return -1;
> +
> + return 0;
> +}
next prev parent reply other threads:[~2013-11-08 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 12:04 Phil Muldoon
2013-10-23 20:46 ` Tom Tromey
2013-11-07 16:35 ` Phil Muldoon
2013-11-07 17:08 ` Tom Tromey
2013-11-07 20:42 ` Doug Evans
2013-11-08 14:42 ` Phil Muldoon
2013-11-08 17:08 ` Doug Evans [this message]
2013-11-11 21:03 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21117.6425.284003.919541@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).