From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30479 invoked by alias); 8 Nov 2013 17:02:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30462 invoked by uid 89); 8 Nov 2013 17:02:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-ob0-f202.google.com Received: from Unknown (HELO mail-ob0-f202.google.com) (209.85.214.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 08 Nov 2013 17:02:26 +0000 Received: by mail-ob0-f202.google.com with SMTP id gq1so351736obb.5 for ; Fri, 08 Nov 2013 09:02:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=9ftvLJbsiIANyZNX9f8W+mJox7t8135EP7rDqq/fuQ0=; b=MDsajdwMjOUoOvVQ2bR9Tikb12u1N6Er4x4l1DOICQkym4fWGHvibkCVQPEO5nzy4n 2NH1/N5EbxuU9p80fAD75gfLeF8HUNFgj81z4Z/p4KCe6XffDvHwP0qwuiHb/E12+BaX aQRWd+vmInVOWOd7HZrIpI2mcd2iuLh+aGzlqzKs/x7ji6C98TvF6u86QtdOmrL16iFn p3bsLnvS1DhKSQ4YNUYXCHvimtzB5acxTChLkjhTGO2Cq+1PqMo36Xkd13QKHhNW3f8A dktqDgQNo/9ow2kQ/ngweXMLdnBERYTiFKtMzdd8qCFOA0W4bj+w177A+q+wAyx0pbEL 4yPQ== X-Gm-Message-State: ALoCoQmBCmJZXGSQN95ePwG81pevcdGa18m5LpVO5fbdHnSkKF3FHrGN+hFtLFftbzqIGfa+lkNvHNe2NI3JEM5X8A2Mx8bUydzdDS7RxziT59YSFV/dWeLqrQIXwZqL1TM+sUd/9lJxEGM67ke+W7AhXu+Enuco4CHWGeIBvKun0QAejay7eO5jU18ighiAms09vGQ1rMvZs46pPRIwyvyEjZsWlSKtRA== X-Received: by 10.42.37.143 with SMTP id y15mr4437720icd.26.1383930138573; Fri, 08 Nov 2013 09:02:18 -0800 (PST) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id k47si975284yha.2.2013.11.08.09.02.18 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Nov 2013 09:02:18 -0800 (PST) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id CE0C731C2C8; Fri, 8 Nov 2013 09:02:17 -0800 (PST) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21117.6425.284003.919541@ruffy.mtv.corp.google.com> Date: Fri, 08 Nov 2013 17:08:00 -0000 To: Phil Muldoon Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch][python] 1/3 Python representation of GDB line tables (Python code) In-Reply-To: <527CF370.9030808@redhat.com> References: <5253F4D4.1050600@redhat.com> <87ob6fd8c7.fsf@fleche.redhat.com> <527BC0F3.1080800@redhat.com> <21115.62285.436813.473271@ruffy.mtv.corp.google.com> <527CF370.9030808@redhat.com> X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00245.txt.bz2 Phil Muldoon writes: > I've made the requested changes. For the sake of brevity I have just > included the three file diffs this time around instead of mailing the > whole series. > > This OK? Thanks. "works for me" [I missed a few things in my previous review. Blech. Mea culpa. There's a couple of function comments that don't have a blank line between them and their function. How could I have missed that??? :-) Ok with those changes, no need for another iteration on my account. Thanks again. > +/* Deconstructor for the line table object. Decrement the reference > + to the symbol table object before calling the default free. */ Here. > +static void > +ltpy_dealloc (PyObject *self) > +{ > + linetable_object *obj = (linetable_object *) self; > + > + Py_DECREF (obj->symtab); > + Py_TYPE (self)->tp_free (self); > +} > + > +/* Initialize LineTable, LineTableEntry and LineTableIterator > + objects. */ Here. > +int > +gdbpy_initialize_linetable (void) > +{ > + if (PyType_Ready (&linetable_object_type) < 0) > + return -1; > + if (PyType_Ready (&linetable_entry_object_type) < 0) > + return -1; > + if (PyType_Ready (<py_iterator_object_type) < 0) > + return -1; > + > + Py_INCREF (&linetable_object_type); > + Py_INCREF (&linetable_entry_object_type); > + Py_INCREF (<py_iterator_object_type); > + > + if (gdb_pymodule_addobject (gdb_module, "LineTable", > + (PyObject *) &linetable_object_type) < 0) > + return -1; > + > + if (gdb_pymodule_addobject (gdb_module, "LineTableEntry", > + (PyObject *) &linetable_entry_object_type) < 0) > + return -1; > + > + if (gdb_pymodule_addobject (gdb_module, "LineTableIterator", > + (PyObject *) <py_iterator_object_type) < 0) > + return -1; > + > + return 0; > +}