From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id C9A733858D28 for ; Tue, 22 Aug 2023 16:54:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9A733858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RVb7144szz4qgm; Tue, 22 Aug 2023 16:54:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVb713JP2z4f9j; Tue, 22 Aug 2023 16:54:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692723293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nKjWmDRKLOzi99eAFc8kOmrSvofEm5qCrU97q/lkPRk=; b=YtX6xQ8RgBytKxPbuiGIGLeFQx8VK1HAhovl0OdySaJl66F5f4eVxd4lf7wnrNqjNIZIyx rNNid/FwpbxseBpRut7ReQr0GOm7/O2ts+H03mye8+DmiPcNaAPfgdmkSbtTvdrq2X9Emu 67CmEkaXnn/yL9LfX2fbkAHAY/TRQMe2pYqHQi9yP7a9qB210pywdfAqbYTZTbQq5dw0vH xTZ43RxAjKtc2t8e2MDoV2mOY0AIpnTjNpaoSJuvkoDCbe7GAhTRAcEDD5LHLb49vrf8ad sMdQc2hjXJFoxj/AQH9lSWqyEMZtASMs2AgiUitP1p4MGA25IuBV6gZvG3S/xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692723293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nKjWmDRKLOzi99eAFc8kOmrSvofEm5qCrU97q/lkPRk=; b=Cz8xsC73cm/2Sg9EZ+w7ckbAhfYjA3nAIOyIYBFH6assSVIPBmo6lKrZYmVICqpxfWgPSb nBCJffLzIa+wTS7rZVvSr3hVrEvtWPfMneKUQXNTVU41WjxJYItw7uDuWlmbcYrLBrfhPb J1oJQpJS+FlEf3rFx8wvsR5lccpBDo5TbuRFdNBYFLWupLXOxKhMdhSe5wUoqBt0MSypJP aueMM/RBhFNSo6HATyNZ+CZ7iGw2nPnkqXXomGrqmsFtU4tYeEnUIZj4pCEyJsykB95+An +Ye4NbmR0E2z5DHiAk2mkTFNgwW8y1CrRJC05YoBcghnpLuG8mYD/ysuTRFM8A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692723293; a=rsa-sha256; cv=none; b=rzt9vbCOk8vvYAI9TBtokD5QAYzBKxkfl4r7B8yhdakHVAWaV2GnGEHAhrKSdNXXqVhC4y SzX+29YIY58uixWINgckvcmchrw5aSV88kfHYWyrwR9p4fhXTD7RULDSZWQ2yveV6eRlCP mUxDgSLEmQvflchC6TSKLLTtGQXQZiI424Go0NZFgoUsS33EdnNV7+55nNy49oAsf7dqAi A+0JRoOfe0oVk0DQHsw50En58kRVE/4N0pe0nlmFd9Ez2gD90Q7qXIq1UgafPa12MzjQhr aTDgdA+dvZRTumXdsJ0gc7rsALzBppEvqcmwnJuhS36wQEFx3tdDCjjlTTSf5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:648:8683:a9e0:1540:43a7:53c2:72f9] (unknown [IPv6:2601:648:8683:a9e0:1540:43a7:53c2:72f9]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RVb706ymCz17ty; Tue, 22 Aug 2023 16:54:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <21142ce3-d74b-dce3-0734-842a8a34db21@FreeBSD.org> Date: Tue, 22 Aug 2023 09:54:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 0/3] Fix thread exited messages for remote targets Content-Language: en-US To: Pedro Alves , Andrew Burgess , gdb-patches@sourceware.org References: <327aa847-c856-5644-af0e-640151694fb1@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/22/23 6:07 AM, Pedro Alves wrote: > On 2023-08-21 17:10, John Baldwin wrote: > >> One question I have is why is the optional metadata specifically a >> ULONGEST exit code rather than just a std::string suffix?  If it were >> a string then windows-nat.c could use something like: >> >>    std::string info = string_printf ("with code %u", (unsigned) exit_code). >>    delete_thread_with_info (to_del, info, silent); >> > > The idea was that if other targets want to print something, it'll probably > be the thread exit code as well, so keeping the text formatting centralized > ensures any such target prints it in the same way. For example, the remote > target's "thread exit" stop reply is "wNN", but we're not printing that thread > exit code today. Remote debugging with Windows gdbserver ideally would want > to print it, I think. On Linux, we also have access to the lwp's exit code, > though I think that in practice it's always 0. Ok, fair enough. -- John Baldwin