From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simark@simark.ca>, Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] [gdb/tui] Fix tui compact-source a bit more
Date: Mon, 15 May 2023 06:03:28 +0200 [thread overview]
Message-ID: <211a52ce-35af-bec4-ec28-27ed8e596d5f@suse.de> (raw)
In-Reply-To: <87sfc12y1n.fsf@tromey.com>
On 5/12/23 20:40, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>>> Just wondering: it makes sense to let the user scroll down all the
>>> way,
>>> until the point where line 5 is the first line in the window. However,
>>> do we need to print line numbers for lines that are after the end of the
>>> source file? In other words, could we leave lines 6-11 blank, and
>>> therefore we could keep using just one digit?
>
> Tom> This demonstrator patch implements that approach.
>
> FWIW I'd be fine with this.
Submitted the patch here (
https://sourceware.org/pipermail/gdb-patches/2023-May/199568.html ).
Thanks,
- Tom
prev parent reply other threads:[~2023-05-15 4:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 13:21 Tom de Vries
2023-05-10 15:28 ` Tom Tromey
2023-05-11 14:55 ` Simon Marchi
2023-05-11 17:45 ` Tom de Vries
2023-05-12 18:40 ` Tom Tromey
2023-05-15 4:03 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211a52ce-35af-bec4-ec28-27ed8e596d5f@suse.de \
--to=tdevries@suse.de \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).