From: Guinevere Larsen <blarsen@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Guarantee that an SAL's end is right before the next statement
Date: Fri, 8 Dec 2023 10:09:46 +0100 [thread overview]
Message-ID: <211ce810-3789-5d34-e7db-6da9c36e3ceb@redhat.com> (raw)
In-Reply-To: <87lea5j0ym.fsf@tromey.com>
On 07/12/2023 19:56, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <blarsen@redhat.com> writes:
> Guinevere> With this new change, the edge case is removed from the processing of
> Guinevere> the 'until' command without regressing the accompanying test case, and
> Guinevere> no other regressions were observed in the testsuite.
>
> Guinevere> Regression tested on fedora 37 with GCC and clang.
>
> Thanks for the patch.
>
> It's pretty hard to reason about this kind of thing. SALs are sort of a
> grab bag of behavior.
>
> Anyway, I read the explanation and it made sense; and you tested it. So
> I think we should try it out.
>
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
>
Thank you! I've just pushed this
--
Cheers,
Guinevere Larsen
She/Her/Hers
prev parent reply other threads:[~2023-12-08 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 8:57 Guinevere Larsen
2023-11-14 10:50 ` [PING][PATCH] " Guinevere Larsen
2023-11-21 17:22 ` [PINGv2][PATCH] " Guinevere Larsen
2023-11-28 9:17 ` Guinevere Larsen
2023-12-07 17:13 ` [PINGv4][PATCH] " Guinevere Larsen
2023-12-07 18:56 ` [PATCH] " Tom Tromey
2023-12-08 9:09 ` Guinevere Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211ce810-3789-5d34-e7db-6da9c36e3ceb@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).