From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] psymtab.c cleanup: remove "partial" from function names
Date: Wed, 15 Jan 2014 02:39:00 -0000 [thread overview]
Message-ID: <21205.62676.570941.871817@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <21154.25694.686399.458157@ruffy.mtv.corp.google.com>
Doug Evans writes:
> Doug Evans writes:
> > Hi.
> >
> > This last patch removes "partial" from the names of
> > expand_partial_symbol_names and map_partial_symbol_filenames.
> > It also renames expand_partial_symbol_names to match the
> > struct quick_symbol_functions "method" that it wraps:
> > expand_symtabs_matching.
> >
> > This patch also adds two parameters to expand_symtabs_matching
> > so that it can fully wrap the underlying quick_symbol_functions method.
> > This makes it usable in more places.
> > I thought of having a cover function that still had the same
> > signature as the old expand_partial_symbol_names function,
> > but I couldn't think of a good name, and it wasn't clear it was
> > worth it anyway.
> >
> > 2013-12-06 Doug Evans <dje@google.com>
> >
> > * symfile.h (expand_symtabs_matching): Renamed from
> > expand_partial_symbol_names. Update prototype.
> > (map_symbol_filenames): Renamed from map_partial_symbol_filenames.
> > * symfile.c (expand_symtabs_matching): Renamed from
> > expand_partial_symbol_names. New args file_matcher, kind.
> > Rename arg fun to symbol_matcher.
> > (map_symbol_filenames): Renamed from map_partial_symbol_filenames.
> > * ada-lang.c (ada_make_symbol_completion_list): Update to call
> > expand_symtabs_matching.
> > (ada_add_global_exceptions): Call expand_symtabs_matching.
> > * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update to
> > call map_symbol_filenames.
> > * symtab.c (sources_info): Update to call map_symbol_filenames.
> > (search_symbols): Call expand_symtabs_matching.
> > (default_make_symbol_completion_list_break_on): Update to call
> > expand_symtabs_matching.
> > (make_source_files_completion_list): Update to call
> > map_symbol_filenames.
>
> Hi.
> I missed a few instances of expand_partial_symbol_names.
> Revised patch attached.
>
> 2013-12-06 Doug Evans <dje@google.com>
>
> * symfile.h (expand_symtabs_matching): Renamed from
> expand_partial_symbol_names. Update prototype.
> (map_symbol_filenames): Renamed from map_partial_symbol_filenames.
> * symfile.c (expand_symtabs_matching): Renamed from
> expand_partial_symbol_names. New args file_matcher, kind.
> Rename arg fun to symbol_matcher.
> (map_symbol_filenames): Renamed from map_partial_symbol_filenames.
> * ada-lang.c (ada_complete_symbol_matcher): Renamed from
> ada_expand_partial_symbol_name.
> (ada_make_symbol_completion_list): Update to call
> expand_symtabs_matching.
> (ada_add_global_exceptions): Call expand_symtabs_matching.
> * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update to
> call map_symbol_filenames.
> * symtab.c (sources_info): Update to call map_symbol_filenames.
> (search_symbols): Call expand_symtabs_matching.
> (symbol_completion_matcher): Renamed from expand_partial_symbol_name.
> (default_make_symbol_completion_list_break_on): Update to call
> expand_symtabs_matching.
> (make_source_files_completion_list): Update to call
> map_symbol_filenames.
I have committed this.
prev parent reply other threads:[~2014-01-15 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 22:35 Doug Evans
2013-12-06 23:57 ` Doug Evans
2014-01-15 2:39 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21205.62676.570941.871817@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).