From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>, Yao Qi <yao@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: [PATCH 0/3] Add debug_printf and timestamps to gdbserver
Date: Thu, 16 Jan 2014 23:28:00 -0000 [thread overview]
Message-ID: <21208.27400.695984.88504@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <52D82AD5.7000306@redhat.com>
Pedro Alves writes:
> On 01/16/2014 06:43 PM, Doug Evans wrote:
> > On Thu, Jan 16, 2014 at 9:22 AM, Pedro Alves <palves@redhat.com> wrote:
>
> > A counter-proposal is that no information is lost given that if PROG
> > isn't present you know it's gdbserver, and it makes the debugging
> > output consistent with the rest of gdbserver.
> > Otherwise "Consistency Is Good" is going to make me want to prepend
> > PROG to all gdbserver output, which I don't have a problem with, but
> > thought I'd double check.
>
> OK, I'll concede. Let's try going without.
>
> >>> diff --git a/gdb/gdbserver/utils.c b/gdb/gdbserver/utils.c
> >>> index eff4499..1ce5512 100644
> >>> --- a/gdb/gdbserver/utils.c
> >>> +++ b/gdb/gdbserver/utils.c
> >>
> >> Could this new debug support code be put in a new file
> >> instead? E.g., gdbserver/debug.c ?
> >
> > It's a pretty-small file, and utils.c is kind of our collective
> > kitchen sink for such things.
>
> Well, I/we've been trying to stop kitchen sinks. It makes
> turning things into libraries much easier. See the "common"
> project wiki page, for example. Things grow into kitchen sinks
> little by little. Before you know it, the beast is huge.
>
> > I have no preference, just double checking that that's what you want.
>
> It is.
>
> >> It'd be nice if this and gdb_assert.h's version of the same were
> >> shared. That is, e.g., put this in common/common-utils.h instead,
> >> and make gdb_assert.h define ASSERT_FUNCTION as FUNCTION_NAME
> >> (or eliminate ASSERT_FUNCTION entirely). Are you planning on
> >> doing it?
> >
> > Done in v2.
>
> Thanks.
v2 is now split into three parts:
1/3 - move ASSERT_FUNCTION to FUNCTION_NAME in common-utils.h
2/3 - create new function delim_string_to_char_ptr_vec_append in gdb_vecs.c
3/3 - the actual debug_printf patch
I went with --debug[=timestamp] as the option naming.
next prev parent reply other threads:[~2014-01-16 23:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 21:47 [PATCH 4/6] gdbserver: Delimit debugging output for readability Doug Evans
2013-12-18 11:17 ` Pedro Alves
2014-01-15 0:47 ` Doug Evans
2014-01-16 17:22 ` Pedro Alves
2014-01-16 18:43 ` Doug Evans
2014-01-16 18:54 ` Pedro Alves
2014-01-16 23:28 ` Doug Evans [this message]
2014-01-16 23:31 ` [PATCH 1/3] gdbserver debug_printf+timestamps: FUNCTION_NAME Doug Evans
2014-01-17 12:46 ` Pedro Alves
2014-01-16 23:33 ` [PATCH 2/3] gdbserver debug_printf+timestamps: delim_string_to_char_ptr_vec_append Doug Evans
2014-01-16 23:37 ` [PATCH 3/3, doc RFA] gdbserver debug_printf+timestamps: main patch Doug Evans
2014-01-17 2:58 ` Doug Evans
2014-01-17 7:04 ` Eli Zaretskii
2014-01-17 12:46 ` Pedro Alves
2014-01-17 22:45 ` Doug Evans
2014-01-18 8:25 ` Eli Zaretskii
2014-01-20 16:14 ` Pedro Alves
2014-01-22 23:06 ` Doug Evans
2014-01-16 18:39 ` [PATCH 4/6] gdbserver: Delimit debugging output for readability Yao Qi
2014-01-16 19:01 ` Doug Evans
2014-01-17 2:32 ` Joel Brobecker
2014-01-17 2:40 ` Joel Brobecker
2014-01-17 12:46 ` Pedro Alves
2014-01-17 12:59 ` Yao Qi
2014-01-20 5:42 ` Tom Tromey
2014-01-20 19:51 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21208.27400.695984.88504@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).