Re: [RFC][PATCH] Allow JIT unwinder provide symbol information

[Doug Evans <dje@google.com>]

Alexander Smundak writes:
 > diff --git a/gdb/jit-reader.in b/gdb/jit-reader.in
 > index 6e2ee64..a6a0ab1 100644
 > --- a/gdb/jit-reader.in
 > +++ b/gdb/jit-reader.in
 > @@ -336,6 +413,7 @@ struct gdb_reader_funcs
 >    gdb_read_debug_info *read;
 >    gdb_unwind_frame *unwind;
 >    gdb_get_frame_id *get_frame_id;
 > +  gdb_get_symbol_attr *get_symbol_attr;
 >    gdb_destroy_reader *destroy;
 >  };
 > 

Hi.

I think the easiest thing to do to preserve version 1 support would be to reorganize this to:

@@ -336,6 +413,7 @@ struct gdb_reader_funcs
   gdb_read_debug_info *read;
   gdb_unwind_frame *unwind;
   gdb_get_frame_id *get_frame_id;
   gdb_destroy_reader *destroy;
+  gdb_get_symbol_attr *get_symbol_attr;
 };


and then have the code that dereferences get_symbol_attr first check that the interface is version 2.

Can you do that?
And any needed doc updates.

And then with that I think(!) we can finally check this in.