From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22696 invoked by alias); 11 Apr 2014 18:47:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22685 invoked by uid 89); 11 Apr 2014 18:47:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f74.google.com Received: from mail-yh0-f74.google.com (HELO mail-yh0-f74.google.com) (209.85.213.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Apr 2014 18:47:08 +0000 Received: by mail-yh0-f74.google.com with SMTP id f10so828225yha.3 for ; Fri, 11 Apr 2014 11:47:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=1FsgsqCQzyix0gObXl7u9ffU640HRIYoBBwVCdE6c0c=; b=CGIV8s00FD+j72je8zpL36L5HNuUddzzvyl8qmn+nhsC+x8cD9pK1EDAEngVRlYyni aFhfJUvuNYCd3kn7pOPOspQanscR80SaTnkxiKlN89EIXQOwbGAPNNe9BGwfOIJLtCc4 0Urms86YmZhFgY23TQqHU3Fqdu7ZKdotnqpsNeUpaBxgy2l5A0ipg4omOfF56imYPm2m XTOkAkdrsS672NKvJ0c6sQo24Zb2xGv6a4VyR4xdhaFjYwJboQHYJ/SanXBLUZDBJ8pp LfH3qkS7XhSDA7e7ZjETzfdG5tHuZ2GPrL+hL3mDDcK87RpzGpijBlfptkgxIbZoQzDt 34gg== X-Gm-Message-State: ALoCoQkeup5GYviKFOok9T6dNT2ECZaQn59HB5zKT0RYaJKkeVCRE4lMPKuU5cmyRhBUcwZAUgoc7ExGvP3X9x3+bscizdh7oVSfGP7Qf/5pbGeZPYbNF6CHMsPOABsLosNOs6g/ch3XJUTNj3JUdnSlt1vR/lZVoaHFqEEBW7bzWuGuyZnaxe8HpdDoBgtgqLsmd+Oqnott4lI4tgzTmiV77d4NlzuKwg== X-Received: by 10.58.86.39 with SMTP id m7mr4412619vez.26.1397242026503; Fri, 11 Apr 2014 11:47:06 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id g21si1254038yhe.3.2014.04.11.11.47.06 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 11 Apr 2014 11:47:06 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id CEBCB31C1BB; Fri, 11 Apr 2014 11:47:05 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21320.14505.266257.89615@ruffy.mtv.corp.google.com> Date: Fri, 11 Apr 2014 18:47:00 -0000 To: Alexander Smundak Cc: gdb-patches@sourceware.org Subject: Re: [RFC][PATCH] Allow JIT unwinder provide symbol information In-Reply-To: References: <20131226183618.D264CA18A0@sasha2.mtv.corp.google.com> <21204.13416.607204.485255@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00214.txt.bz2 Alexander Smundak writes: > diff --git a/gdb/jit-reader.in b/gdb/jit-reader.in > index 6e2ee64..a6a0ab1 100644 > --- a/gdb/jit-reader.in > +++ b/gdb/jit-reader.in > @@ -336,6 +413,7 @@ struct gdb_reader_funcs > gdb_read_debug_info *read; > gdb_unwind_frame *unwind; > gdb_get_frame_id *get_frame_id; > + gdb_get_symbol_attr *get_symbol_attr; > gdb_destroy_reader *destroy; > }; > Hi. I think the easiest thing to do to preserve version 1 support would be to reorganize this to: @@ -336,6 +413,7 @@ struct gdb_reader_funcs gdb_read_debug_info *read; gdb_unwind_frame *unwind; gdb_get_frame_id *get_frame_id; gdb_destroy_reader *destroy; + gdb_get_symbol_attr *get_symbol_attr; }; and then have the code that dereferences get_symbol_attr first check that the interface is version 2. Can you do that? And any needed doc updates. And then with that I think(!) we can finally check this in.