From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 3E1C73986C05 for ; Wed, 9 Jun 2021 14:46:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E1C73986C05 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2E094219B1; Wed, 9 Jun 2021 14:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623250014; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bcEyO6bTUpIMYxLgdG0/ckRDuT4FeT2f7oNnFOuTTw8=; b=S/lyb48atWBW3N74OAWKDvd+/UYJnBZihRl4Q3F6SsLpowxa7yXc/I3lYv6lQWeTGtK0Qd j3/T8SD/jUv7BKRcfGdLygRt5i8qAUlcJR+lbcpKnkK6IRDuKETXs+lQEak6QHJbiPeSPH jpyVvjDKbZ/RzTLDUoOUavaluRIN8Tw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623250014; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bcEyO6bTUpIMYxLgdG0/ckRDuT4FeT2f7oNnFOuTTw8=; b=yCc+rQmm4WzBDmonnKozsAEAjuY3Rre2eB6wo01ZUrahwpcRzoq7N48QRz+UUDLy8Xlifo JO/ghStauNjkC3DQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 07767118DD; Wed, 9 Jun 2021 14:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623250014; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bcEyO6bTUpIMYxLgdG0/ckRDuT4FeT2f7oNnFOuTTw8=; b=S/lyb48atWBW3N74OAWKDvd+/UYJnBZihRl4Q3F6SsLpowxa7yXc/I3lYv6lQWeTGtK0Qd j3/T8SD/jUv7BKRcfGdLygRt5i8qAUlcJR+lbcpKnkK6IRDuKETXs+lQEak6QHJbiPeSPH jpyVvjDKbZ/RzTLDUoOUavaluRIN8Tw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623250014; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bcEyO6bTUpIMYxLgdG0/ckRDuT4FeT2f7oNnFOuTTw8=; b=yCc+rQmm4WzBDmonnKozsAEAjuY3Rre2eB6wo01ZUrahwpcRzoq7N48QRz+UUDLy8Xlifo JO/ghStauNjkC3DQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id /NmwAF7UwGDNWQAALh3uQQ (envelope-from ); Wed, 09 Jun 2021 14:46:54 +0000 Subject: Re: [PATCH 1/5] Remove gdb/testsuite/configure To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org References: <20210528192743.508390-1-tromey@adacore.com> <20210528192743.508390-2-tromey@adacore.com> <874kehsn2y.fsf@tromey.com> <87lf7jjebe.fsf@tromey.com> From: Tom de Vries Message-ID: <213bc19a-93f9-9b55-5313-c72909b8eb63@suse.de> Date: Wed, 9 Jun 2021 16:46:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <87lf7jjebe.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 14:46:57 -0000 On 6/9/21 4:35 PM, Tom Tromey wrote: >>> Sure. If anybody relies on being able to do this without using 'make', >>> there's already a 'read1' convenience target that can be used. >>> >>> I'm going to check this in with this change. > > Tom> Personally I'm fine with no longer supporting this. But perhaps others > Tom> use READ1=1 in combination with some nonstandard make target? I'm not sure. > > There's no way to know. True. > We can restore the old behavior if you think that's worthwhile. > I think it's ok to leave things as they are, and reconsider if somebody actually complains. > Tom> Anyway, if we decide to leave things as they are now, we should document > Tom> this in gdb/testsuite/README: > Tom> ... > Tom> Examples: > > Tom> make -j10 check-read1 TESTS="*/paginate-*.exp" > Tom> - make -j10 check READ1="1" > Tom> ... > > How about the appended? > LGTM. Thanks, - Tom > commit 6bd42c74ef9b1838c9a0151fb089188de4b80e5f > Author: Tom Tromey > Date: Wed Jun 9 08:34:47 2021 -0600 > > Update read1 example in gdb/testsuite/README > > Tom de Vries noticed that the recent changes to the testsuite's > configury required an update to the README. This patch changes the > text to document the new reality. > > gdb/testsuite/ChangeLog > 2021-06-09 Tom Tromey > > * README (Example): Update read1 example. > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index 92894d6efab..bd06a4433fd 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,7 @@ > +2021-06-09 Tom Tromey > + > + * README (Example): Update read1 example. > + > 2021-06-08 Lancelot Six > > * gdb.base/premature-dummy-frame-removal.py (TestUnwinder): Use > diff --git a/gdb/testsuite/README b/gdb/testsuite/README > index 0036753eff0..862f423a988 100644 > --- a/gdb/testsuite/README > +++ b/gdb/testsuite/README > @@ -347,9 +347,13 @@ return at most 1 byte. > To enable this, either pass a non-empty value in the READ1 make > variable, or use the check-read1 make target instead of check. > > -Examples: > +Example: > > make -j10 check-read1 TESTS="*/paginate-*.exp" > + > +If you've already built the read1 support code, either via a previous > +'check-read1' run, or by using "make read1", you can use: > + > make -j10 check READ1="1" > > Note: While the intention is to detect races and make otherwise passing tests >