From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29123 invoked by alias); 23 Feb 2015 16:33:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28958 invoked by uid 89); 23 Feb 2015 16:33:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: bigwig.baldwin.cx Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 23 Feb 2015 16:33:13 +0000 Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3711EB91F; Mon, 23 Feb 2015 11:33:11 -0500 (EST) From: John Baldwin To: Pedro Alves Cc: gdb-patches@sourceware.org, Mark Kettenis Subject: Re: [PATCH] Fix signal trampoline detection/unwinding on recent FreeBSD/i386 and FreeBSD/amd64 Date: Mon, 23 Feb 2015 16:33:00 -0000 Message-ID: <2144163.poMfT1VBCC@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <54E2757A.2020808@redhat.com> References: <11386216.Yv1qECs4Mc@ralph.baldwin.cx> <5792555.u7sbdTrmvU@ralph.baldwin.cx> <54E2757A.2020808@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2015-02/txt/msg00669.txt.bz2 On Monday, February 16, 2015 10:55:54 PM Pedro Alves wrote: > On 02/16/2015 04:37 PM, John Baldwin wrote: > > On Wednesday, February 11, 2015 04:40:17 PM Pedro Alves wrote: > >> On 02/11/2015 03:32 PM, John Baldwin wrote: > >>> Actually, this does sound far simpler. I was simply updating the > >>> sigtramp > >>> code that was already present. I can certainly work on changing both > >>> i386 > >>> and amd64 to do this instead if that is the preferred method (and it > >>> seems > >>> to be from looking at other targets). > >> > >> Yep, that's the preferred method. That'd be great. > > > > I've implemented this and attached the updated patch below. I'm not quite > > sure if the updated Changelog is correct however. I ran into one hiccup > > though which is that the signal trampoline code is not included in process > > core dumps in recent FreeBSD versions (after it was moved off of the stack > > and into a global shared page). I've fixed this in FreeBSD so that > > future versions will include the trampoline in core dumps, but I've > > retained the change to use KERN_PROC_SIGTRAMP to support core dumps from > > the versions that do not include it in the core. I've removed the > > support for specifying a signal trampoline location for older verions > > using either hardcoded offsets or ps_strings as it is no longer needed. > > Looks great to me! Mark, any comments? > > (I see a couple minor formatting issues, but I can fix them up > for you before pushing.) Just pinging about this (I haven't see a mail from Mark, so I assume you are waiting on that?) -- John Baldwin