Re: [PATCH] Deprecate MI version 1

[Luis Machado <luis.machado@arm.com>]

On 9/21/22 18:07, Simon Marchi via Gdb-patches wrote:
> 
> 
> On 2022-09-21 12:47, Tom Tromey wrote:
>> MI version 1 is long since obsolete.  Rather than remove it
>> immediately (though I did send a patch for that), instead let's
>> deprecate it in GDB 13 and then remove it for GDB 14.
>> ---
>>   gdb/NEWS | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index 555ef2ddf77..e834e97dacc 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -3,6 +3,8 @@
>>   
>>   *** Changes since GDB 12
>>   
>> +* MI version 1 is deprecated, and will be removed in GDB 14.
>> +
>>   * GDB now supports dumping memory tag data for AArch64 MTE.  It also supports
>>     reading memory tag data for AArch64 MTE from core files generated by
>>     the gcore command or the Linux kernel.
> 
> 
> LGTM.  Do you think it would be worth printing a warning when
> initializing an mi1 interp, something like this?  There might be some
> people using / maintaing some frontend somewhere that are more likely to
> see this than the NEWS file.
> 
> 
>From f2d148e8787d1c4b4c1c4218646a87157f5fac82 Mon Sep 17 00:00:00 2001
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Wed, 21 Sep 2022 13:06:47 -0400
> Subject: [PATCH] warn
> 
> Change-Id: Ia38707b24ce0d0ab519b189464ded828f5669c27
> ---
>   gdb/interps.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/gdb/interps.c b/gdb/interps.c
> index 3a9c590b8c87..c26bc0f0f6fd 100644
> --- a/gdb/interps.c
> +++ b/gdb/interps.c
> @@ -171,11 +171,16 @@ interp_set (struct interp *interp, bool top_level)
>     if (interpreter_p != interp->name ())
>       interpreter_p = interp->name ();
>   
> +  bool warn_about_mi1 = false;
> +
>     /* Run the init proc.  */
>     if (!interp->inited)
>       {
>         interp->init (top_level);
>         interp->inited = true;
> +
> +      if (streq (interp->name (), "mi1"))
> +	warn_about_mi1 = true;
>       }
>   
>     /* Do this only after the interpreter is initialized.  */
> @@ -185,6 +190,10 @@ interp_set (struct interp *interp, bool top_level)
>     clear_interpreter_hooks ();
>   
>     interp->resume ();
> +
> +  if (warn_about_mi1)
> +    warning (_("MI version 1 is deprecated and will be removed in a future "
> +	       "version, please upgrade to a newer MI version."));
>   }

We should probably be more explicit about deprecating it for GDB 13 and then removing
it in GDB 14. What do you think?