From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) by sourceware.org (Postfix) with ESMTPS id 657F03858400 for ; Thu, 22 Sep 2022 17:00:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 657F03858400 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cCc7/qjx0/T44CylP84fAMeVB33dfPTP9R29I/D5MeL6EWHOFA3/xK6NSOTUkEyqMrDsxeOK9iGgndaOiFqmi75Nl+ra7aeoFwcP13jyUO6hYqFR+3Qx2BxMjxqJcDUwcwjrjzhEKGhr4s5FcwVMn766ls8kQY8Tacz88ohZOmK5GYw5/Lj4Cz1/4yfsuPbUXJxTrnvAuhNlwQdCCbNRiF047h5Y6fyVMBKLRmcM8QNeI3yISrMPoixkv41uycPL5vi3+UbAhb7UwPZu9lt9UOD5bB5habgFcvO5bXevIUQc5j1QLR0x5V5Xlp6GCnTL7MdHkxDjW6cIgaNtcDOLVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5gbHY5afBddF5RkMD9wow8bf3yBQjNVsw1q5IIiB/L4=; b=XcX08uTBPQRq7keFou5erV5P/psSE2PHmcGVgu0zP/Y7yj+D8GRlgvaFqOWRJUzglFB/1zbNbFbRx2JBKqH71inIJfBxMqwyXVgTDtHFiq0nyl9tZyp0kng2u53kd+VPt5oQdicHxavd1cKzsU/qEg7PHpheT9X/ba1eEYw8vDaVuiSmzc+GRipKw35iTX2T/G8DV6mcyv3DPOYdC4cJXbmRiybZeC01KSWilyI4/fECrKbzVABV/uOZyL9PpmEBN5nNIfpK4JiNbQY9qy34ZqFz3sGmEliNNX01/2LMfKb7p53pD/zoNfMJAU8EM3wYxHjtQzymZAH7tbiTAF49Rw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB6P191CA0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::16) by AS2PR08MB9199.eurprd08.prod.outlook.com (2603:10a6:20b:578::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Thu, 22 Sep 2022 17:00:24 +0000 Received: from DBAEUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::26) by DB6P191CA0006.outlook.office365.com (2603:10a6:6:28::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18 via Frontend Transport; Thu, 22 Sep 2022 17:00:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT056.mail.protection.outlook.com (100.127.142.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 17:00:23 +0000 Received: ("Tessian outbound fc2405f9ecaf:v124"); Thu, 22 Sep 2022 17:00:23 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 76917d26d1115dc6 X-CR-MTA-TID: 64aa7808 Received: from 12efa4b70f5c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 70EF9D54-743F-4F5A-B9CF-EE1A98E93230.1; Thu, 22 Sep 2022 17:00:16 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 12efa4b70f5c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 22 Sep 2022 17:00:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ace2/VRXGi3onPt9JgRCDrG+Tp+ZHSClPxRDjCfo5P7cTA/q4NzSzjTZReNfASH+fFx0y4jvk/wUEzkaVhYdEVHgs5nMm02TXoXYoRr7W3xLJmq09IWvAf99O0G96wf6nqLTElpF9pVDGBy1Dr+6F2tV+J3THVJmZ2h+a2p0SkBSen4B1LXUX59W3+ifYmkH4pdUHIN9WZVPSoUda3JDLL86DYtp3CyxfivVGcLZAjJ6Fzr2BlCyF9OpSoWlM0UgEyE8SjrzJ64aRks+LIR8wUrPs78rCWsYukl45Bt1SGXD0mwTAwdf4s6gjOmTKD4k0duWYjBO4fTydOlviw71vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5gbHY5afBddF5RkMD9wow8bf3yBQjNVsw1q5IIiB/L4=; b=kKelYkwoNjtwGLUrp/T1Xw8Oen17nE51bJnWpWV4BX5Kr9LQax/CyH8wBAzeXsmTQnxdVZqdo6Ne5PAvkDV2bhwoAbWALw6D52RznNyEBQq4ejvD4Rr/p8bleEoon/YLGDT0ODf6Up6foWRrvODAo4palTkm7zwx1/a34W4FC/9dMKG0rulfnk6Z1YTkJZeqCltiiqvcnppYYb26Y5AKd3qVeRCVR755kVl5UrKVsGyr9UruKSefeaxfJWgIwAkWArALRznXGJevl+z2MzEVrZskbZFlmCSt8BSdT63E+3J/pYDAxmzYnr+ZF029ONiGDzHW6xSP0bETpc5uDO7+nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VI1PR08MB5342.eurprd08.prod.outlook.com (2603:10a6:803:132::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Thu, 22 Sep 2022 17:00:14 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 17:00:14 +0000 Message-ID: <21454591-3de4-c6a5-2545-496d2a9ed979@arm.com> Date: Thu, 22 Sep 2022 18:00:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Deprecate MI version 1 Content-Language: en-US To: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org References: <20220921164737.3258130-1-tom@tromey.com> <2d5c442d-5a2b-4340-1151-e01c1051d895@simark.ca> From: Luis Machado In-Reply-To: <2d5c442d-5a2b-4340-1151-e01c1051d895@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0050.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::16) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|VI1PR08MB5342:EE_|DBAEUR03FT056:EE_|AS2PR08MB9199:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b4f5d12-7b7f-4cca-c966-08da9cbbf0ca x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zCBuxWFSrO1gYISVQMZdp7kQAJgNAUqtDuEDFy1JkARt2zKxa4OAzbtokqG5Y5WHqFIWgSGRiYG20Y5psp2jYcqjImQrA0XgqX153NCLBirh3f7caB1CTGoyIG+nLHesiHvdM5KKgaLQq6Ws7foogTQuSyj4uVcFOHWB02G2KKsOin0eD+Jcr/PE7Y1nl8zCxgyOA1oPRAVUT2PFWZySRuti8XTBvZwfi4l8q+lYY8nqYq/4EH8PN7qNgeondQBWYd8XK4N+UHHp0TzsvJxKFXgQNdGxay0euQDpSeun9FEV+kdBZkfIDbHMCbME3l0tKJc3wPcQy0HslivzxxX5S75qwlnKiClxfQ5X4pn54Wz52+L4f+SnkgD7Nqi7B+VRvKcOxKuiSiAp+r0rjLjrjrbA5v0huprT67V41vW34/lTxn9qZl9873nF/+EMkrmlcvaHlrGqqjko6Cp3K2I/3y9bUNqHsYa/YQ1p3L3AVu+Py4ooLUHKEX8c7M5CfFGDqQlmKDpXG7dBqmXIsAAXbMP717BNjSNBRk0YumvvIaduArWc9E/vUUvp1EQcvN5RL7tTl++Y1xIH1wcwFyg7vUVcTp+L32p3x01RlQXLkyIo+N386Z+BgV1azEWHt2SQwgumzPOqvkdkG7+I4B/3yF+9J6gOPdOGPCKtcts5dr3Wb+sTAHVmQ94S0y+kbfWJJ8bT/f0yB0HJErl7auxTz1U8/0CenOy475h0IeHVKfn199cGsRKOFY8kHnQSdaWSJ8ILHmSX+cWEwAQtIiUp4CmlgMa34WdaStsoTvZHE+g= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(451199015)(36756003)(6506007)(8936002)(26005)(41300700001)(2616005)(53546011)(66476007)(66556008)(66946007)(8676002)(6512007)(38100700002)(186003)(86362001)(31696002)(83380400001)(44832011)(2906002)(316002)(5660300002)(31686004)(478600001)(6486002)(110136005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5342 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ca6cc38-7cb2-4913-6005-08da9cbbeb45 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DAh+XGEkQ4a5POcTT0OlZMqi8T/hkPcng/GVuuHztUmp5fXRVZskZ6PqdCPYVYy9uwrvQZiy6SwaunxiXvVJlnfVNXyUVgZdW03a2O5URVpKsRasSiDr8dlmL052DQpd6OyORl/WUTWdFOvcufupLMQhRS38gWyjUFSaT0QWxFfvSJ6CZh4ac3VZNbaW12oDI3uO886WVuOsgpNSVlhC+3vK0KwK4BV19mdiBS0buVyYJsS3ye7yQoH988XU3mTkwo4ABZl9/BsMH3Q69r+15b/HQRnQ+W7FhezB0n1EL/vNA38nWPzUNqAe7LCDebeJAEEJdLd+mQHcX048Y62BuZNPi/pBJfgNuKHzhWXTbwXJfapP5YVHruBWl5uLoOCqZ9gsqRC21t3loBe+Iyo5VY0Sh3i1fkciDrul0mcpj/eA4kb765NKCpKKJUiprbvro0YJ+NpT+0396e7hF7pADEHgizs/mggeGyURodgrvQAP7AZUPcuNw7Xd52mC7JAs5NGugYcpiRrDjXETxFF3FwSJtOG3xGdDOU6EnoM1kdiURjg1MwierPtSUUNngKo0JKte+lZNxKB5s0H1SLmkCX27xgQ0gtIS4MH1Dry/tY7rquSjdzytCnhUFHXnbqNE+RFUP1TwMgN0toHkNts7401nVSMAlpWN+l7kfCrb6OBctaolgg8RjSVUOp4MqSvROj1gHwsvgnNpTsaI4AL5COVCKYJYaA3LTXCfOb4rm4Iwme3PcwtWO/3GTxsEmUKmStwTjOcdA5lJRZ3z8lvP1REA1DKDsAeCQOpXL835Od8aPYb7rA4F8kVzhWFJFVUl X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(40470700004)(36840700001)(46966006)(83380400001)(41300700001)(2616005)(316002)(82740400003)(47076005)(81166007)(36860700001)(186003)(44832011)(8676002)(2906002)(6506007)(70586007)(8936002)(356005)(82310400005)(40460700003)(40480700001)(6512007)(478600001)(5660300002)(70206006)(6486002)(53546011)(26005)(110136005)(336012)(86362001)(31686004)(36756003)(31696002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 17:00:23.8985 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b4f5d12-7b7f-4cca-c966-08da9cbbf0ca X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9199 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2022 17:00:28 -0000 On 9/21/22 18:07, Simon Marchi via Gdb-patches wrote: > > > On 2022-09-21 12:47, Tom Tromey wrote: >> MI version 1 is long since obsolete. Rather than remove it >> immediately (though I did send a patch for that), instead let's >> deprecate it in GDB 13 and then remove it for GDB 14. >> --- >> gdb/NEWS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 555ef2ddf77..e834e97dacc 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -3,6 +3,8 @@ >> >> *** Changes since GDB 12 >> >> +* MI version 1 is deprecated, and will be removed in GDB 14. >> + >> * GDB now supports dumping memory tag data for AArch64 MTE. It also supports >> reading memory tag data for AArch64 MTE from core files generated by >> the gcore command or the Linux kernel. > > > LGTM. Do you think it would be worth printing a warning when > initializing an mi1 interp, something like this? There might be some > people using / maintaing some frontend somewhere that are more likely to > see this than the NEWS file. > > >>From f2d148e8787d1c4b4c1c4218646a87157f5fac82 Mon Sep 17 00:00:00 2001 > From: Simon Marchi > Date: Wed, 21 Sep 2022 13:06:47 -0400 > Subject: [PATCH] warn > > Change-Id: Ia38707b24ce0d0ab519b189464ded828f5669c27 > --- > gdb/interps.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/gdb/interps.c b/gdb/interps.c > index 3a9c590b8c87..c26bc0f0f6fd 100644 > --- a/gdb/interps.c > +++ b/gdb/interps.c > @@ -171,11 +171,16 @@ interp_set (struct interp *interp, bool top_level) > if (interpreter_p != interp->name ()) > interpreter_p = interp->name (); > > + bool warn_about_mi1 = false; > + > /* Run the init proc. */ > if (!interp->inited) > { > interp->init (top_level); > interp->inited = true; > + > + if (streq (interp->name (), "mi1")) > + warn_about_mi1 = true; > } > > /* Do this only after the interpreter is initialized. */ > @@ -185,6 +190,10 @@ interp_set (struct interp *interp, bool top_level) > clear_interpreter_hooks (); > > interp->resume (); > + > + if (warn_about_mi1) > + warning (_("MI version 1 is deprecated and will be removed in a future " > + "version, please upgrade to a newer MI version.")); > } We should probably be more explicit about deprecating it for GDB 13 and then removing it in GDB 14. What do you think?