From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11547 invoked by alias); 5 Aug 2014 17:16:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11537 invoked by uid 89); 5 Aug 2014 17:16:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f73.google.com Received: from mail-oi0-f73.google.com (HELO mail-oi0-f73.google.com) (209.85.218.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 05 Aug 2014 17:16:20 +0000 Received: by mail-oi0-f73.google.com with SMTP id u20so235570oif.2 for ; Tue, 05 Aug 2014 10:16:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=mz3OrR+8gnqlK90Er2thDnpjCjs4FPAYXGd1oos0XUw=; b=TYgr0sI3oLGe/XVLPZbCh3JOlQx1RBTAuqI+PVwXJDRxg1euHGg5o/Qfl58nsHoghw ZrNXj+LIKOYiqtJVBpQpWFyCRvmrmtR+VmTDlLEsKhYnnZzi8y6pClgH+KqfVkocCz+P y0F7aoNzwSz55xDnO07MwzQXCoH0cinNWFqlu5YLm25Z/a+YySBGlekx0B9L2mYCQ81Y S5emjfzlj1sMaifCpRsgvtYajRjRAQFmDZ6uMAGA89DyPPJUvnrfEUEo9U5OmE+9seyR 52QAroSSDNIb6fQ7lNbX7k5HpNctogP35+lIpIutRkMz7becX1s0E/omnJHle8YuBiNb xE+A== X-Gm-Message-State: ALoCoQlCWe/BZkqBSNld4vxZTSBLDcQmlFVjVdDx8GX/qg1oK/biOoiefSCL/5PibpJf5vsacHc6 X-Received: by 10.43.64.202 with SMTP id xj10mr3333991icb.0.1407258979063; Tue, 05 Aug 2014 10:16:19 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id v44si140386yhv.0.2014.08.05.10.16.18 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Aug 2014 10:16:19 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 50FB931C285; Tue, 5 Aug 2014 10:16:18 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21473.4449.767906.303936@ruffy.mtv.corp.google.com> Date: Tue, 05 Aug 2014 17:16:00 -0000 To: Jan Kratochvil Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [commit+7.8] [read_frame_arg patch] Handle partially optimized out values similarly to unavailable values In-Reply-To: <20140722202004.GA14408@host2.jankratochvil.net> References: <20140709103312.GA27884@host2.jankratochvil.net> <53BD2CE0.1000308@redhat.com> <20140709153121.GA7989@host2.jankratochvil.net> <53C41D5D.9030109@redhat.com> <20140716215838.GA29855@host2.jankratochvil.net> <53C7C02A.2090107@redhat.com> <20140720150727.GA18488@host2.jankratochvil.net> <53CEB93A.4020709@redhat.com> <20140722202004.GA14408@host2.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00056.txt.bz2 Jan Kratochvil writes: > On Tue, 22 Jul 2014 21:19:22 +0200, Pedro Alves wrote: > > OK, I've pushed the reversion (without the #if 0 bit) to both master > > and 7.8. > > Therefore pushed in the fix of read_frame_arg together with the testcase. > e214cf6c2e05bcfc85dc6f335d8ffdc3629cf0cf > and also for 7.8: > 0f9e1204f3de3cbe46a2b9e54049c1df9a5df305 > > > Jan > commit e214cf6c2e05bcfc85dc6f335d8ffdc3629cf0cf > Author: Jan Kratochvil > Date: Tue Jul 22 22:09:35 2014 +0200 > > Fix read_frame_arg for optimized-out entry values. > > gdb/ > 2014-07-22 Jan Kratochvil > > * stack.c (read_frame_arg): Verify value_optimized_out before calling > value_available_contents_eq. > > gdb/testsuite/ > 2014-07-22 Jan Kratochvil > > * gdb.arch/amd64-entry-value-paramref.S: New file. > * gdb.arch/amd64-entry-value-paramref.cc: New file. > * gdb.arch/amd64-entry-value-paramref.exp: New file. > * gdb.arch/amd64-optimout-repeat.S: New file. > * gdb.arch/amd64-optimout-repeat.c: New file. > * gdb.arch/amd64-optimout-repeat.exp: New file. > > Message-ID: <20140720150727.GA18488@host2.jankratochvil.net> > Message-ID: <20140711153757.GA452@host2.jankratochvil.net> Hi. In trunk I'm seeing amd64-entry-value-paramref.exp fail with a gdb internal error. I can debug this further if you need me to. (gdb) file testsuite/gdb.arch/amd64-entry-value-paramref [...] (top-gdb) bt #0 internal_error (file=0xa249e8 "../../entry-value/gdb/dwarf2read.c", line=15776, string=0xa28050 "could not find partial DIE 0x%x in cache [from module %s]\n") at ../../entry-value/gdb/utils.c:823 #1 0x00000000006a89cb in find_partial_die (offset=..., offset_in_dwz=0, cu=0x1029370) at ../../entry-value/gdb/dwarf2read.c:15776 #2 0x00000000006a8c9d in fixup_partial_die (part_die=0x103a6f0, cu=0x1029370) at ../../entry-value/gdb/dwarf2read.c:15855 #3 0x0000000000692b49 in scan_partial_symbols (first_die=0x103a690, lowpc=0x7fffffffdb78, highpc=0x7fffffffdb70, need_pc=0, cu=0x1029370) at ../../entry-value/gdb/dwarf2read.c:6567 #4 0x000000000069132a in process_psymtab_comp_unit_reader (reader=0x7fffffffdcc0, info_ptr=0xf6c78c "\002bar", comp_unit_die=0x103a480, has_children=1, data=0x7fffffffdd90) at ../../entry-value/gdb/dwarf2read.c:5913 #5 0x0000000000690662 in init_cutu_and_read_dies (this_cu=0xf5d770, abbrev_table=0x0, use_existing_cu=0, keep=0, die_reader_func=0x690fe2 , data=0x7fffffffdd90) at ../../entry-value/gdb/dwarf2read.c:5529 #6 0x00000000006917d0 in process_psymtab_comp_unit (this_cu=0xf5d770, want_partial_unit=0, pretend_language=language_minimal) at ../../entry-value/gdb/dwarf2read.c:5998 #7 0x0000000000692456 in dwarf2_build_psymtabs_hard (objfile=0x101eab0) at ../../entry-value/gdb/dwarf2read.c:6397 #8 0x000000000068d225 in dwarf2_build_psymtabs (objfile=0x101eab0) at ../../entry-value/gdb/dwarf2read.c:4173 #9 0x0000000000554e9d in read_psyms (objfile=0x101eab0) at ../../entry-value/gdb/elfread.c:1363 [...]