public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
	   "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: time to workaround libc/13097 in fsf gdb?
Date: Sat, 13 Sep 2014 01:06:00 -0000	[thread overview]
Message-ID: <21523.39044.768702.981508@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <5412E3AC.80203@redhat.com>

Pedro Alves writes:
 > On 09/12/2014 12:54 PM, Jan Kratochvil wrote:
 > > On Thu, 11 Sep 2014 18:37:02 +0200, Pedro Alves wrote:
 > >> Also, we know the address of the vDSO/gate (symfile-mem.c).  Can't
 > >> we use that to match instead of the name?
 > > [...]
 > >> ISTR having seen a patch that does that, but I can't seem to find it.
 > > 
 > > Re: [patch+7.5.1] Work around PR libc/13097 "linux-vdso.so.1" #3
 > > https://sourceware.org/ml/gdb-patches/2012-11/msg00636.html
 > > Message-ID: <20121125181505.GA26194@host2.jankratochvil.net>
 > > 
 > > It is pending/unreviewed/unapproved.
 > 
 > Ah, yeah, I think that was it.
 > 
 > I was more inclined to leave the vdso in the shared library list
 > though, like ldd does, than filtering it out.

I like this too.
No point in hiding it from the user.

 > Like, similar to
 > your gdbarch_solib_file_not_found_is_ok patch, but look at the
 > addresses rather than filenames in the hook.  I'm not sure
 > whether that'd complicate things too much.

I'm not sure either.

It *would* be nice to connect the processing of vdso when seen
by svr4_read_so_list (called during shared library loading)
with add_syscall_page (called as an observer when an inferior
is created).  The same file (vdso) is processed in two disparate places
with no linkage for the human reader between them - a bit confusing.

 > > Also I am not sure it is really still an issue on latest upstream glibc, it is
 > > not an issue on Fedora 21 x86_64 glibc with the reproducer from:
 > > 	https://sourceware.org/bugzilla/show_bug.cgi?id=13097
 > > 
 > > (That is old Fedoras workarounded it in glibc, then some Fedoras exposed the
 > > issue in GDB but now it is not visible - so either Fedoras workaround it again
 > > or just upstream glibc switched/workarounds it also.)

I downloaded glibc 2.20 and tested it with gdb 7.8.
Still an issue.
[I just did a simple build, if there's a configure option
that will fix things I didn't try one.]
I think FSF gdb 7.8[.1?] (the latest) should work with FSF glibc 2.20
(the latest).

  parent reply	other threads:[~2014-09-13  1:06 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 16:25 Doug Evans
2014-09-11 16:37 ` Pedro Alves
2014-09-12 11:55   ` Jan Kratochvil
2014-09-12 12:14     ` Pedro Alves
2014-09-12 12:33       ` Jan Kratochvil
2014-09-12 12:46         ` Pedro Alves
2014-09-17 20:10           ` Jan Kratochvil
2014-09-19 14:38             ` Pedro Alves
2014-09-19 14:41               ` Pedro Alves
2014-09-20 21:30                 ` Jan Kratochvil
2014-09-21 19:12                   ` Pedro Alves
2014-09-21 19:46                     ` Pedro Alves
2014-09-23 23:05                       ` Doug Evans
2014-09-26 12:09                         ` Pedro Alves
2014-09-22 18:35                     ` Jan Kratochvil
2014-09-23 11:49                       ` Pedro Alves
2014-09-28 13:41                         ` Jan Kratochvil
2014-09-29 10:36                           ` Pedro Alves
2014-10-03 13:09                             ` Gary Benson
2014-10-07 23:16                             ` Doug Evans
2014-09-23 12:05                       ` Pedro Alves
2014-09-26 12:05                       ` Pedro Alves
2014-09-23 10:59                     ` automated testing comment [Re: time to workaround libc/13097 in fsf gdb?] Jan Kratochvil
2014-09-23 12:32                       ` Pedro Alves
2014-09-23 12:45                         ` Jan Kratochvil
2014-09-23 13:30                           ` Pedro Alves
2014-09-23 13:57                             ` Jan Kratochvil
2014-09-23 14:48                               ` Pedro Alves
2014-09-23 15:53                                 ` Jan Kratochvil
2014-09-23 15:56                                   ` Pedro Alves
2014-09-24 13:22                                 ` Andreas Arnez
2014-09-24 15:23                                   ` Ulrich Weigand
2014-09-25  7:11                                     ` Andreas Arnez
2014-09-25  8:20                                     ` Pedro Alves
2014-09-25 10:52                                       ` Jan Kratochvil
2014-09-23 14:54                           ` Doug Evans
2014-09-23 15:16                         ` Simon Marchi
2014-09-23 14:48                       ` Doug Evans
2014-09-23 14:59                         ` Pedro Alves
2014-09-20 19:50               ` time to workaround libc/13097 in fsf gdb? Jan Kratochvil
2014-09-23 11:18                 ` Pedro Alves
2014-09-23 13:16                   ` Gary Benson
2014-10-09 20:09                   ` Jan Kratochvil
2014-10-09 22:07                     ` Pedro Alves
2014-09-13  1:06       ` Doug Evans [this message]
2014-09-17 20:13         ` Jan Kratochvil
2014-09-23 21:35         ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21523.39044.768702.981508@ruffy2.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).