From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20792 invoked by alias); 14 Oct 2014 21:03:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20771 invoked by uid 89); 14 Oct 2014 21:03:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-oi0-f73.google.com Received: from mail-oi0-f73.google.com (HELO mail-oi0-f73.google.com) (209.85.218.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 14 Oct 2014 21:03:07 +0000 Received: by mail-oi0-f73.google.com with SMTP id u20so3315298oif.0 for ; Tue, 14 Oct 2014 14:03:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=to60eapwFpmCl4iekhkghfFuhQen3bXn4AnEx2AZNYI=; b=TYKeVqKtZPcxGeJPCLMHPoMGyYJBEu7acMg+JU4CPkxIWCrSFvc4ZUxsmlgXkqivE2 UuE8mtpgxgKdWwLnw7GxIPBGxP3Tc+PvlsZGf7IVWN8cdo0U3EfgrHWIG17McwgdBw8Z Mu8UR4eKBlHu/uqhi+ysE9+lv222xxGM4moVzhIchjh+nZTZLD3WQjNlPfmLX8gYWb2A 21Fb/Uo/NyvYs4PkNNoIo+EbsCDrHWovCqxqP4tlKitJPQs9PGVPi7R0bJdepC6zpKSq RgoNIZIRBlviVKPMJvkO6i/pL9nlI23C2z0Lkc4o+KN6aOXbx8HFDHRFyq+7lRYNLFvQ e7kA== X-Gm-Message-State: ALoCoQnSSKr0+TLPUqLs77SUiQHb/ob/0Ppu832rlFvehDRBtfteSf9/8GSA8jvkxutTm5UPrsCvfxY9RLYcYKC0xBChjwlruEUAr7Jed6/8jpUnyv5H5RkCnoXm0113IKAPXU6VGIyBlqFlOqPhGHw8U/LWOp4oQ/iFPpMsPHE65aX3f1PyNZI= X-Received: by 10.182.2.106 with SMTP id 10mr5332294obt.27.1413320585081; Tue, 14 Oct 2014 14:03:05 -0700 (PDT) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id l45si877276yha.2.2014.10.14.14.03.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Oct 2014 14:03:05 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTP id F8eFTPGl.1; Tue, 14 Oct 2014 14:03:04 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21565.36744.3600.919624@ruffy2.mtv.corp.google.com> Date: Tue, 14 Oct 2014 21:03:00 -0000 To: Siva Chandra Cc: gdb-patches Subject: Re: [PATCH 2/4] PR c++/13403 and PR c++/15154: Fix gnuv3_pass_by_reference to lookup copy c-tors with qualified args In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00370.txt.bz2 Siva Chandra writes: > On Sun, Sep 28, 2014 at 11:01 PM, Doug Evans wrote: > >> 2014-09-11 Siva Chandra Reddy > >> > >> PR c++/13403 > >> PR c++/15154 > >> * gdbtypes.c (make_qualified_type): Make non-static. > >> * gdbtypes.h (make_qualified_type): Declare. > >> * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy > >> constructors with qualified args > > > Can you use class_types_same_p here (instead of comparing with the > > result of make_qualified_type) ? > > Yes, I made this change now. The patch is attached. > > I am assuming that the other patches in this series are approved > modulo making the test regexes more specific. > > gdb/ChangeLog: > > 2014-09-29 Siva Chandra Reddy > > PR c++/13403 > PR c++/15154 > * gnu-v3-abi.c (gnuv3_pass_by_reference): Lookup copy constructors > with qualified args. LGTM. And yeah, the rest of the patch set is approved. [Modulo the potential addition of a comment in 4/4.]