From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 375 invoked by alias); 3 Dec 2014 02:39:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32741 invoked by uid 89); 3 Dec 2014 02:38:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-pd0-f202.google.com Received: from mail-pd0-f202.google.com (HELO mail-pd0-f202.google.com) (209.85.192.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 03 Dec 2014 02:38:33 +0000 Received: by mail-pd0-f202.google.com with SMTP id w10so1939550pde.3 for ; Tue, 02 Dec 2014 18:38:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:subject:in-reply-to :references; bh=l/nM+H/h3oI8wTrgNulGBndhPCVe8ByceHlhKQV8+HU=; b=eHOwDVrxbrYH+n7EnrevEaEZAaLG/xjIRn/LfCeEjqdHnS5mJhw2S5EW9VUyWF7fif XXTqYDLMIwKRtvnZSgwIDjM/04zG07M3VU0GgGJsBqMl1Ir+dxW6qcYEPPeZMt53aj2T J7n3IWCela0Tt7Wdy5ZftwP2Z4l1v4I+eX+6ecq4iSRzhVv69wGOr1pTL5Rc8XvwGaXy jk3jkGOYGZ/Ww+8CV/h7jy2ArxsbRmdcTg1DS+uEiepGs7EXYthRDt8dP4OIDGi3wI9z 1m/8avXOMKsb3ely22g0MNLiFEMpeP9rB2Myc2M2uDsao2N1wlW4g0RF6SRYmTupo+S1 WgVg== X-Gm-Message-State: ALoCoQm3ImEYDVqX/x1y2pC29xTvNa4Wc8Tqqp3Sl717pNbzSTA1QhgWZEKjVztZPCt1mB3Awia4 X-Received: by 10.70.36.167 with SMTP id r7mr2556921pdj.1.1417574311698; Tue, 02 Dec 2014 18:38:31 -0800 (PST) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id e24si926244yhe.3.2014.12.02.18.38.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Dec 2014 18:38:31 -0800 (PST) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTP id g2tsmQCS.1; Tue, 02 Dec 2014 18:38:31 -0800 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21630.30630.261031.207300@ruffy2.mtv.corp.google.com> Date: Wed, 03 Dec 2014 02:39:00 -0000 To: gdb-patches@sourceware.org, swagiaal@redhat.com, sergiodj@redhat.com Subject: Re: [PATCH] Remove general_symbol_info.language_specific.cplus_specific In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00046.txt.bz2 Doug Evans writes: > Hi. > > This patch reverts the addition of cplus_specific added here: > > 2010-07-16 Sami Wagiaalla > > * symtab.h (symbol_set_demangled_name): Now takes an optional objfile* > argument. > (cplus_specific): New struct. > * symtab.c (symbol_set_demangled_name): Updated. > Use cplus_specific for cplus symbols. > (symbol_get_demangled_name): Retrive the name from the cplus_specific > struct for cplus symbols. > (symbol_init_language_specific): Set cplus_specific for cplus symbols. > (symbol_set_names): Pass objfile to symbol_set_demangled_name. > * symtab.c (symbol_init_cplus_specific): New function. > > It was added in anticipation of improved template support: > > https://sourceware.org/ml/gdb-patches/2010-05/msg00594.html > https://sourceware.org/ml/gdb-patches/2010-07/msg00284.html > > However, minsyms pay the price for this space too. > For my standard benchmark this patch gets back 44MB of memory > when gdb starts. [There's still ~440MB of memory used > by the demangled ELF symbols of this benchmark, > but that's another topic.] > > When the improved templated support is added, > I wonder if this can be moved to struct symbol. > Hmmm, we already have a special version of > struct symbol for templates (struct template_symbol). > > Regression tested on amd64-linux. > > 2014-11-25 Doug Evans > > * symtab.c (symbol_init_cplus_specific): Delete. > (symbol_set_demangled_name): Remove special c++ support. > (symbol_get_demangled_name, symbol_set_language): Ditto. > * symtab.h (struct cplus_specific): Delete. > (struct general_symbol_info) : Remove > cplus_specific. Committed.