From: Tristan Gingold <gingold@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>,
Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] make first parameter of to_lookup_symbol const char *
Date: Mon, 14 Mar 2011 14:21:00 -0000 [thread overview]
Message-ID: <216AE8CA-D201-42C6-82E5-D507F340FDBE@adacore.com> (raw)
In-Reply-To: <201103141353.10512.pedro@codesourcery.com>
On Mar 14, 2011, at 2:53 PM, Pedro Alves wrote:
> On Monday 14 March 2011 10:13:43, Tristan Gingold wrote:
>
>> is there any good reason why the NAME parameter is 'char *' instead of 'const char *' ? I can't see any of them.
>
> Old code. Original K&R didn't know about const. We have a lot of places
> that could/should be const but aren't. It's an ongoing slow cleanup.
>
>>
>> This patch was tested only by recompiling gdb for powerpc-elf.
>>
>> BTW, it looks like no target defines this operation...
>
> Are you going to add a use of it? Otherwise, I'd rather
> just getting rid of it.
No.
Joel, can we remove that ? I thought we were using it for dfw, but we don't anymore.
Tristan.
next prev parent reply other threads:[~2011-03-14 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 11:56 Tristan Gingold
2011-03-14 13:53 ` Jan Kratochvil
2011-03-16 14:02 ` Joel Brobecker
2011-03-16 15:03 ` Tom Tromey
2011-03-16 20:03 ` Stan Shebs
2011-03-17 14:58 ` Joel Brobecker
2011-03-14 14:03 ` Pedro Alves
2011-03-14 14:21 ` Tristan Gingold [this message]
2011-03-15 8:26 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=216AE8CA-D201-42C6-82E5-D507F340FDBE@adacore.com \
--to=gingold@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).