From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id 3BBDC3857BBB for ; Wed, 25 May 2022 13:35:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3BBDC3857BBB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id x12so5914705wrg.2 for ; Wed, 25 May 2022 06:35:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tR4b33lNOEOyatnJUgqHtrsM7APu4eUc+L4Kip4zJw4=; b=ErrGbZpX5iUk+W6NOCTTsAzyMRsGHNApTB/cSe32ZIla4pp/ZPArgg+jhsJ6/7eH4i +Kp1N8s2ObMG0scj9P9NipqAqTwMipGtIMDPMgJJbB/3loEiAZQMmwmX1g/dxyfJA2DW 1wAGcMEf9KWPiLpJ+udbgThY1hc/49PFH3hS0a2ekpbGGNxD+bE49caJIe5HcmoKPZGv HA9AADQi2Ro1NIJb1tvGtdrl2+EbOI2uLuwvK1VVuSGCDlh911F5m2AU9jvaGaYYeun/ 5o7lZNx3wHSGeARfEqa/YJKkKz+GdwXF6tLsu/70woJSXCbGhsJUgj8kdWbJOZfpt9pa 1eBQ== X-Gm-Message-State: AOAM532aVThijuBwwwLaOfCVLQ/j6OVZDIbVS+hWABiFTB7v+PpWOTG5 +aqXTYa3DMPjxQF+JzMq651p7oCMfHw= X-Google-Smtp-Source: ABdhPJzYduE6LDr+mq4Yplr+EN2JOjpjjYfUtCIDsqpizFr8EFrLa5GFfhNeqcF2uksqamnC75/pAQ== X-Received: by 2002:adf:f706:0:b0:20e:6788:c2b6 with SMTP id r6-20020adff706000000b0020e6788c2b6mr26283031wrp.633.1653485727737; Wed, 25 May 2022 06:35:27 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id a22-20020a05600c2d5600b003942a244f49sm1689899wmg.34.2022.05.25.06.35.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 06:35:26 -0700 (PDT) Message-ID: <216e9d86-dff8-66ad-dd39-fcfd721d12c4@palves.net> Date: Wed, 25 May 2022 14:35:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] gdb/linux-nat: xfer_memory_partial return E_IO on error Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20220525092957.2969989-1-lancelot.six@amd.com> From: Pedro Alves In-Reply-To: <20220525092957.2969989-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 13:35:30 -0000 On 2022-05-25 10:29, Lancelot SIX via Gdb-patches wrote: > When accessing /proc/PID/mem, if pread64/pwrite64/read/write encounters > an error and return -1, linux_proc_xfer_memory_partial return > TARGET_XFER_EOF. > > I think it should return TARGET_XFER_E_IO in this case. TARGET_XFER_EOF > is returned when pread64/pwrite64/read/frite returns 0, which indicates > that the address space is gone and the whole process has exited or > execed. > > This patch makes this change. > > Regression tested on x86_64-linux-gnu. > OK.