From: Doug Evans <dje@google.com>
To: Alexander Smundak <asmundak@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: RFC: Python gdb.Type method returning optimized out gdb.Value
Date: Wed, 29 Apr 2015 05:20:00 -0000 [thread overview]
Message-ID: <21824.10641.108664.534077@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <CAHQ51u5PUkcWPV0TfGG2EL9vuLhpbVjDnFUwXjhd76d2f-Gs0Q@mail.gmail.com>
Alexander Smundak writes:
> Thank you for the quick review.
> Edited NEWS, renamed `create_optimized_out' to `optimized_out',
> elided 'unavailable' from description, added blank line.
> PTAL.
>
Hi.
Here is what I committed.
I found a few more nits.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 721346a..4e78d39 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-04-28 Sasha Smundak <asmundak@google.com>
+
+ * NEWS: Mention gdb.Type.optimized_out method.
+ * python/py-type.c (typy_optimized_out): New function.
+
2015-04-28 John Baldwin <jhb@FreeBSD.org>
* fbsd-nat.c: Include "gdb_wait.h" instead of <sys/wait.h>.
diff --git a/gdb/NEWS b/gdb/NEWS
index b711553..d463b52 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -52,6 +52,8 @@
which is the name of the objfile as specified by the user,
without, for example, resolving symlinks.
** You can now write frame unwinders in Python.
+ ** gdb.Type objects have a new method "optimized_out",
+ returning optimized out gdb.Value instance of this type.
* New commands
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 5da9943..13ca87b 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,7 @@
+2015-04-28 Sasha Smundak <asmundak@google.com>
+
+ * python.texi: New method documented.
+
2015-04-24 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.texinfo (Dump/Restore Files): Add detail about verilog dump
diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index 448fa8b2..12d2b71 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -1060,6 +1060,11 @@ If @var{block} is given, then @var{name} is looked up in that scope.
Otherwise, it is searched for globally.
@end defun
+@defun Type.optimized_out ()
+Return @code{gdb.Value} instance of this type whose value is optimized
+out. This allows a frame decorator to indicate that the value of an
+argument or a local variable is not known.
+@end defun
Each type has a code, which indicates what category this type falls
into. The available type categories are represented by constants
diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
index 39376a1..648d8c8 100644
--- a/gdb/python/py-type.c
+++ b/gdb/python/py-type.c
@@ -1181,6 +1181,16 @@ typy_nonzero (PyObject *self)
return 1;
}
+/* Return optimized out value of this type. */
+
+static PyObject *
+typy_optimized_out (PyObject *self, PyObject *args)
+{
+ struct type *type = ((type_object *) self)->type;
+
+ return value_to_value_object (allocate_optimized_out_value (type));
+}
+
/* Return a gdb.Field object for the field named by the argument. */
static PyObject *
@@ -1493,6 +1503,9 @@ They are first class values." },
{ "const", typy_const, METH_NOARGS,
"const () -> Type\n\
Return a const variant of this type." },
+ { "optimized_out", typy_optimized_out, METH_NOARGS,
+ "optimized_out() -> Value\n\
+Return optimized out value of this type." },
{ "fields", typy_fields, METH_NOARGS,
"fields () -> list\n\
Return a list holding all the fields of this type.\n\
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 1967aca..80d88cf 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-04-28 Sasha Smundak <asmundak@google.com>
+
+ * gdb.python/py-type.exp: New test.
+
2015-04-28 Andy Wingo <wingo@igalia.com>
* gdb.python/py-parameter.exp:
diff --git a/gdb/testsuite/gdb.python/py-type.exp b/gdb/testsuite/gdb.python/py-type.exp
index 9e522f2..58a2394 100644
--- a/gdb/testsuite/gdb.python/py-type.exp
+++ b/gdb/testsuite/gdb.python/py-type.exp
@@ -253,6 +253,9 @@ gdb_test "python print(gdb.lookup_type('char').array(1, 0))" \
gdb_test "python print(gdb.lookup_type('char').array(1, -1))" \
"Array length must not be negative.*"
+gdb_test "python print(gdb.lookup_type('int').optimized_out())" \
+ "<optimized out>"
+
with_test_prefix "lang_c" {
runto_bp "break to inspect struct and array."
test_fields "c"
prev parent reply other threads:[~2015-04-29 0:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 20:33 Alexander Smundak
2015-04-07 17:44 ` Doug Evans
2015-04-07 21:23 ` Alexander Smundak
2015-04-12 16:48 ` Doug Evans
2015-04-13 23:57 ` Doug Evans
2015-04-14 2:43 ` Eli Zaretskii
2015-04-29 5:20 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21824.10641.108664.534077@ruffy2.mtv.corp.google.com \
--to=dje@google.com \
--cc=asmundak@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).