From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A12E93858D1E for ; Thu, 12 Oct 2023 04:30:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A12E93858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 39C4TwRM014902 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Oct 2023 00:30:03 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 39C4TwRM014902 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1697085003; bh=b6mS8XirvZqGG8Sqoux9Z/biucscFRwF0GzCwFIECqU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=H8zItaYGUVpdcovKhwR2RywiDCkL6ywcENts+mfR1W/bPen44IL9N5ueDnXsdv1tT 6uD29lro6sW2D3mLDb9JlgWAmN4ZprN2hO1hGUsdkb7ZtIfemPIAWHAx4YEnZsdNwZ xPzCJBTXkgN2vdYs+t+CmSStpBOUJlVXQZ4dSEuk= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 978331E00F; Thu, 12 Oct 2023 00:29:58 -0400 (EDT) Message-ID: <21a013ea-83d3-49d3-80c6-ca8477e3d60b@polymtl.ca> Date: Thu, 12 Oct 2023 00:29:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 05/13] nat/x86-cpuid.h: Remove non-x86 fallbacks Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org Cc: Willgerodt@smtp.polymtl.ca, Felix , George@smtp.polymtl.ca, Jini Susan References: <20231009183617.24862-1-jhb@FreeBSD.org> <20231009183617.24862-6-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20231009183617.24862-6-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 12 Oct 2023 04:29:58 +0000 X-Spam-Status: No, score=-3037.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-09 14:36, John Baldwin wrote: > This header is only suitable for use on x86 hosts and is only included > there, so these fallbacks should not be needed. > --- > gdb/nat/x86-cpuid.h | 22 ---------------------- > 1 file changed, 22 deletions(-) > > diff --git a/gdb/nat/x86-cpuid.h b/gdb/nat/x86-cpuid.h > index e1b0321d593..9401705c44d 100644 > --- a/gdb/nat/x86-cpuid.h > +++ b/gdb/nat/x86-cpuid.h > @@ -28,8 +28,6 @@ > #define nullptr ((void *) 0) > #endif > > -#if defined(__i386__) || defined(__x86_64__) > - > /* Return cpuid data for requested cpuid level, as found in returned > eax, ebx, ecx and edx registers. The function checks if cpuid is > supported and returns 1 for valid cpuid information or 0 for > @@ -78,26 +76,6 @@ x86_cpuid_count (unsigned int __level, unsigned int __sublevel, > return __get_cpuid_count (__level, __sublevel, __eax, __ebx, __ecx, __edx); > } > > -#else > - > -static __inline int > -x86_cpuid (unsigned int __level, > - unsigned int *__eax, unsigned int *__ebx, > - unsigned int *__ecx, unsigned int *__edx) > -{ > - return 0; > -} > - > -static __inline int > -x86_cpuid_count (unsigned int __level, unsigned int __sublevel, > - unsigned int *__eax, unsigned int *__ebx, > - unsigned int *__ecx, unsigned int *__edx) > -{ > - return 0; > -} > - > -#endif /* i386 && x86_64 */ > - > #ifndef __cplusplus > /* Avoid leaking this local definition beyond the scope of this header > file. */ I think that one could go in right away. Approved-By: Simon Marchi Simon