On 01/26/2018 03:50 AM, Joel Brobecker wrote:
> Hi Pedro,
> 
>>> I'm curious to know if after all the fixing you still see
>>> the KFAIL on your end.  I get:
>>>
>>>   KPASS: gdb.ada/maint_with_ada.exp: maintenance check-psymtabs (PRMS gdb/22670)
> 
> I just started looking at this, and I am wondering whether your binder-
> generated file looks like, and in particular whether it has the
> following kind of declaration in b~var_arr_typedef.ads:
> 
>    u00045 : constant Version_32 := 16#f60287af#;
>    pragma Export (C, u00045, "interfaces__cS");
> 
> IIRC, these are version consistency checks that are used by
> the distributed system annex. If you don't have those in this file,
> for some reason, then it would explain why you don't see the issue.

Indeed, looks like I don't have that.  I have "interfacesS".
I've attached the whole file.

Running:

 $ grep Export ./testsuite/outputs/gdb.ada/maint_with_ada/b~var_arr_typedef.ads | sed 's/.*, \"//' | sed 's/").*//g' | c++filt

I notice that none of the Export symbols I have demangles as a C++ symbol,
while "interfaces__cS" (the one you have) does:

 $ echo "interfaces__cS" | c++filt 
 interfaces(char, signed)

So it may be that we still need to add another special case
for Ada somewhere.  Would old GDB from before the C++
wildmatching pass this test for you?

Thanks,
Pedro Alves