From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 4EF713858D38 for ; Wed, 10 Jan 2024 10:24:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EF713858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4EF713858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704882272; cv=none; b=a4NacfeXxTdT0tEc6ooIjM5CIqKSyA4rOmnmye/sMN2CUaZOcJZSWg70T9YxYWUJ+ya0HE6GDxWMdqgWp0cPwXyss6uB2JfM+A7gN6k1pjoPvm4oEjYSRNHSHb27AWBCPv+vTWwYwjOpmLiIEfge7eYG6EE+M7q/NIMP182C3KY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704882272; c=relaxed/simple; bh=WdL+mHWOB2gd/pA21XqzeC9JbzysCuMUJFS968LfxlA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=A/ZiA8Jv5M883hUdgNuk2DPRSi/5H/hF+Mx6zA5E3ntyirrDd4vQ4wT4hnPWLbThHgToX9EuW97sAr/eCZwc52jGZj51xMse1mMnTfZrWrsvTHl+XPHE3QPwI0Cf/wxhKuiQWsUh0pWMtJITM4es3OWVpKSxbXYn7Kkq9Euu0yU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 14EFC21EF7; Wed, 10 Jan 2024 10:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704882269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBzURHeg6SrRvzsRbWwKXgWD6g9MgHOS535fqRXJlUI=; b=DLbQ9Wu2Q9XN3r6AiTnfQbG16Ng9P7+3HbpCW2fuYk8yoz7l/IC8ZJmxnfRQUFAJ2wq2uq 4LreGc6tsJSt7EMtpk/LpcJDDlLzgqwjfWoNCoWq5/6AaKMeg+sOfe32c/1lvsGesyXdxx ihRww68PoizoFpHXT/BRg+DQnfkvnjc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704882269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBzURHeg6SrRvzsRbWwKXgWD6g9MgHOS535fqRXJlUI=; b=qgYuH0A0JBL7KaEA+l8DlEjBB4hVQ883/0FLqLOwpmcMFZie8BDnPHoY87mmqxmK71rnIY 14Yve2A+EhWFbGCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704882269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBzURHeg6SrRvzsRbWwKXgWD6g9MgHOS535fqRXJlUI=; b=DLbQ9Wu2Q9XN3r6AiTnfQbG16Ng9P7+3HbpCW2fuYk8yoz7l/IC8ZJmxnfRQUFAJ2wq2uq 4LreGc6tsJSt7EMtpk/LpcJDDlLzgqwjfWoNCoWq5/6AaKMeg+sOfe32c/1lvsGesyXdxx ihRww68PoizoFpHXT/BRg+DQnfkvnjc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704882269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBzURHeg6SrRvzsRbWwKXgWD6g9MgHOS535fqRXJlUI=; b=qgYuH0A0JBL7KaEA+l8DlEjBB4hVQ883/0FLqLOwpmcMFZie8BDnPHoY87mmqxmK71rnIY 14Yve2A+EhWFbGCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F086513CB3; Wed, 10 Jan 2024 10:24:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UNlIOVxwnmW9bAAAD6G6ig (envelope-from ); Wed, 10 Jan 2024 10:24:28 +0000 Message-ID: <21c4fbe8-9acb-4a68-a09b-acd1e50af4d9@suse.de> Date: Wed, 10 Jan 2024 11:25:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] [gdb] Fix assertion failure for checkpoint delete 0 Content-Language: en-US To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20240108152553.4578-1-tdevries@suse.de> <20240108152553.4578-4-tdevries@suse.de> <20240109222819.42d20c22@f39-zbm-amd> From: Tom de Vries In-Reply-To: <20240109222819.42d20c22@f39-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spam-Level: X-Spamd-Bar: / Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DLbQ9Wu2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qgYuH0A0 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-0.80 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.30)[74.86%]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_HI(-3.50)[suse.de:dkim]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(3.50)[1.000]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: -0.80 X-Rspamd-Queue-Id: 14EFC21EF7 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/10/24 06:28, Kevin Buettner wrote: > On Mon, 8 Jan 2024 16:25:53 +0100 > Tom de Vries wrote: > >> When doing "checkpoint delete 0" we run into an assertion failure: >> ... >> +delete checkpoint 0 >> inferior.c:406: internal-error: find_inferior_pid: Assertion `pid != 0' failed. >> ... >> >> Fix this by handling the "pptid == null_ptid" case in >> delete_checkpoint_command. >> >> Tested on x86_64-linux. >> >> PR gdb/31209 >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id > > The Bug URL above is missing an '=31209' at the end. > > Otherwise, LGTM. > > Approved-By: Kevin Buettner Thanks for the reviews. The linaro CI found: ... (gdb) PASS: gdb.base/checkpoint-ns.exp: delete checkpoint 0: checkpoint restart 1 Switching to Thread 0xfffff7ff7e60 (LWP 146669) #0 main () at /home/tcwg-build/workspace/tcwg_gnu_0/abe/snapshots/gdb.git~master/gdb/testsuite/gdb.base/checkpoint.c:28 28 char *tmp = &linebuf[0]; (gdb) FAIL: gdb.base/checkpoint-ns.exp: delete checkpoint 0: restart 1 ... so I'll commit shortly with this minor update: ... - gdb_test "restart 1" "Switching to process $decimal\r\n.*" + gdb_test "restart 1" "Switching to .*" ... Thanks, - Tom