From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B54433857024 for ; Wed, 7 Oct 2020 02:45:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B54433857024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 63CAF1E58E; Tue, 6 Oct 2020 22:45:18 -0400 (EDT) Subject: Re: [PATCH 02/10] Include elf_64_file_p in the netbsd_process_target class To: Kamil Rytarowski , gdb-patches@sourceware.org References: <20201002021804.2814-1-n54@gmx.com> <20201002021804.2814-3-n54@gmx.com> From: Simon Marchi Message-ID: <21fccf3d-3b54-426c-0f7b-6087ab2f353e@simark.ca> Date: Tue, 6 Oct 2020 22:45:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201002021804.2814-3-n54@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2020 02:45:19 -0000 On 2020-10-01 10:17 p.m., Kamil Rytarowski wrote: > gdbserver/ChangeLog: > > * netbsd-low.cc (elf_64_file_p): Turn into... > (netbsd_process_target::elf_64_file_p): ...this. > * netbsd-low.h (netbsd_process_target::elf_64_file_p): Add. I don't see the point in making this a member function. It doesn't interact with netbsd_process_target class in any way, so low cohesion. So the net result is that if you need to use this quite generic function from outside the netbsd_process_target in the future, you can't. I'm not strongly opposing, since this is not a particularly important matter, I just find it odd. Simon