From: John Baldwin <jhb@freebsd.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 4/6] Use LWP IDs with ptrace register requests on FreeBSD.
Date: Fri, 15 Jan 2016 23:54:00 -0000 [thread overview]
Message-ID: <2254480.0h7heLGpvG@ralph.baldwin.cx> (raw)
In-Reply-To: <5699677F.3040808@redhat.com>
On Friday, January 15, 2016 09:41:19 PM Pedro Alves wrote:
> On 01/15/2016 08:18 PM, John Baldwin wrote:
> > On Thursday, January 14, 2016 03:07:28 PM Pedro Alves wrote:
> >> [Dropping binutils.]
> >>
> >> On 01/13/2016 09:45 PM, John Baldwin wrote:
> >>> This allows gdb to fetch per-thread registers for multi-threaded FreeBSD
> >>> processes. NetBSD and OpenBSD also accept LWP IDs for ptrace requests
> >>> to fetch per-thread state.
> >>
> >> I'd prefer to make inf-ptrace.c:get_ptrace_pid extern and use
> >> it, instead of duplicating it multiple times.
> >
> > This sounds good to me. Do you want me to use it in other places as well?
> > sparc-nat.c at least duplicates the same logic inline. amd64linux-nat.c
> > does as well. If so, would you rather that be a seperate patch (expose
> > get_ptrace_pid() and use it in existing targets) from this patch?
>
> I won't impose that as requirement, but that'd be nice.
Ok. I made a pass and fixed the ones that I thought were relevant (i.e.
generating a pid to pass to ptrace()). However, the vast majority of the
files changed were various foo-linux-nat.c files which I am not setup to
test. Is there a way to push a branch and have the build bots build it to
do a test build? (Even then I think those would not cover 'nat' files for
s390, hppa, etc.) I'm still happy to include this, just want to ensure I
don't break the build. I'm also not sure if changing these files would
break gdbserver (if gdbserver doesn't include inf-ptrace.o).
--
John Baldwin
next prev parent reply other threads:[~2016-01-15 23:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 21:46 [PATCH v2 0/6] Support kernel-backed user threads " John Baldwin
2016-01-13 21:46 ` [PATCH v2 6/6] Dump register notes for each thread when generating a FreeBSD core John Baldwin
2016-01-14 15:34 ` Pedro Alves
2016-01-13 21:46 ` [PATCH v2 3/6] Display per-thread information for threads in FreeBSD cores John Baldwin
2016-01-14 15:03 ` Pedro Alves
2016-01-15 20:23 ` John Baldwin
2016-01-18 12:27 ` Pedro Alves
2016-01-18 17:06 ` John Baldwin
2016-01-18 17:13 ` Pedro Alves
2016-01-13 21:46 ` [PATCH v2 2/6] Add a psuedosection for the NT_FREEBSD_THRMISC note John Baldwin
2016-01-14 5:30 ` Alan Modra
2016-01-13 21:46 ` [PATCH v2 1/6] Add support to readelf for reading FreeBSD ELF core notes John Baldwin
2016-01-14 5:30 ` Alan Modra
2016-01-14 5:40 ` John Baldwin
2016-01-13 21:52 ` [PATCH v2 4/6] Use LWP IDs with ptrace register requests on FreeBSD John Baldwin
2016-01-14 15:07 ` Pedro Alves
2016-01-15 20:23 ` John Baldwin
2016-01-15 21:41 ` Pedro Alves
2016-01-15 23:54 ` John Baldwin [this message]
2016-01-16 14:39 ` Pedro Alves
2016-01-16 19:17 ` John Baldwin
2016-01-13 21:52 ` [PATCH v2 5/6] Add support for LWP-based threads " John Baldwin
2016-01-14 15:29 ` Pedro Alves
2016-01-15 23:54 ` John Baldwin
2016-01-16 14:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2254480.0h7heLGpvG@ralph.baldwin.cx \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).