From: Pedro Alves <palves@redhat.com>
To: Hannes Domani <ssbssa@yahoo.de>,
Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/4] Attribute method inlining
Date: Fri, 22 May 2020 16:47:47 +0100 [thread overview]
Message-ID: <226240ff-8fa8-e47a-1a3b-0b0f30d41698@redhat.com> (raw)
In-Reply-To: <527321070.2641378.1590081500100@mail.yahoo.com>
On 5/21/20 6:18 PM, Hannes Domani via Gdb-patches wrote:
> Am Donnerstag, 21. Mai 2020, 18:42:23 MESZ hat Pedro Alves <palves@redhat.com> Folgendes geschrieben:
>
>> On 5/21/20 4:03 PM, Hannes Domani via Gdb-patches wrote:
>>>> There was a patch for this not that long ago. Let me try to dig it up.
>>>
>>> You're right, I found it here:
>>> https://sourceware.org/pipermail/gdb-patches/2019-June/158285.html
>>
>> Yes, that's the one!
>>
>>>
>>> So I guess it's not just on Windows that slow.
>>>
>>> And you replied that we maybe should use TOLOWER, ISXDIGIT from libiberty
>>> instead:
>>> https://sourceware.org/pipermail/gdb-patches/2019-June/158518.html
>>
>> This message is actually older than the patch above -- I wrote the patch
>> afterwards.
>>
>> The patch is using the libiberty macros, and avoids the readline clash
>> you run into. Could you give it a try?
>
> It wasn't immediately obvious to me, but I think you mean this one:
> https://sourceware.org/pipermail/gdb-patches/2019-June/158525.html
Oh, wow, I confused the "158525" in the url with "158285". They looked
the same number to me. Sorry. Yes, I meant that patch as you found out.
>
> I tried it, and as expected, I get the same speedup as with my previous
> test, and strcmp_iw_ordered is now in only ~1.5% of the profiling samples.
Awesome. Let me write some git log / ChangeLog for it and resend it as
a separate thread.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-05-22 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 17:40 [PATCH 0/4] Micro-optimize DWARF partial symbol reading Tom Tromey
2020-05-20 17:40 ` [PATCH 1/4] Attribute method inlining Tom Tromey
2020-05-20 19:40 ` Tom Tromey
2020-05-21 1:08 ` Hannes Domani
2020-05-21 14:26 ` Pedro Alves
2020-05-21 15:03 ` Hannes Domani
2020-05-21 16:42 ` Pedro Alves
2020-05-21 17:18 ` Hannes Domani
2020-05-22 15:47 ` Pedro Alves [this message]
2020-05-22 20:28 ` Pedro Alves
2020-05-20 17:40 ` [PATCH 2/4] Lazily compute partial DIE name Tom Tromey
2020-05-20 17:40 ` [PATCH 3/4] Inline abbrev lookup Tom Tromey
2020-05-20 17:40 ` [PATCH 4/4] Use add_partial_symbol in load_partial_dies Tom Tromey
2020-05-20 19:30 ` [PATCH 0/4] Micro-optimize DWARF partial symbol reading Christian Biesinger
2020-05-20 21:08 ` Simon Marchi
2020-05-27 17:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226240ff-8fa8-e47a-1a3b-0b0f30d41698@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).