From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 502243851C36
 for <gdb-patches@sourceware.org>; Fri, 12 Jun 2020 19:53:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 502243851C36
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 5C7111E791;
 Fri, 12 Jun 2020 15:53:39 -0400 (EDT)
Subject: Re: [PATCH] Don't drop static function bp locations w/o debug info
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
References: <20200612192108.11481-1-pedro@palves.net>
From: Simon Marchi <simark@simark.ca>
Message-ID: <22959b69-54bd-012e-4026-feb4f02ac671@simark.ca>
Date: Fri, 12 Jun 2020 15:53:37 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200612192108.11481-1-pedro@palves.net>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jun 2020 19:53:41 -0000

On 2020-06-12 3:21 p.m., Pedro Alves wrote:
> @@ -4371,21 +4336,54 @@ search_minsyms_for_name (struct collect_info *info,
>  
>    if (!minsyms.empty ())

You could remove this check and de-indent the rest.  If minsyms is empty, the loop
will just be skipped over.

Otherwise, LGTM.

Simon