From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id D00253858CDB for ; Mon, 28 Nov 2022 08:35:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D00253858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 15DDC1F891; Mon, 28 Nov 2022 08:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669624525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NypiRBuiH2dDv4BZh5Rrs5aEYN6pCKChdy6Sb4+O/u8=; b=mY0303C11NocPV4j5kuUnAxV0pb+kBI61G2PKGQBdnid6oQoHi8qvRuIukqnicrktlOTAy JzWUGjqgkfOcWJcDb5kVK1EVAqTDuMm6AWvdKxVmeu2zS+dRoyTSZ3Kvvk9h+j/m3naKdN FPM6XkKdutKEl12/UNPff2MaxQUV/c4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669624525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NypiRBuiH2dDv4BZh5Rrs5aEYN6pCKChdy6Sb4+O/u8=; b=JJ9ZNuT0JjB0RjeTzCeGTCBYygmF6FVtiHKzP1YhvG0R6pgy5CXT4dFhQ8nFYhKEW0TVnn rpomLpZRZ+z2QJAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ED05013273; Mon, 28 Nov 2022 08:35:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DcQzOMxyhGPnYAAAMHmgww (envelope-from ); Mon, 28 Nov 2022 08:35:24 +0000 Message-ID: <22ccd823-9331-c693-a3e6-1ba5e4eb3e34@suse.de> Date: Mon, 28 Nov 2022 09:35:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCHv3 0/3] gdb/python: avoid throwing an exception over libopcodes code To: Andrew Burgess , gdb-patches@sourceware.org References: Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/22 17:57, Andrew Burgess via Gdb-patches wrote: > Changes since v2: > > - Rebase onto current upstream/master, no merged conflicts. > > Changes since v1: > > - Patch #1 is largely unchanged. I'm still in discussion with Simon > as to whether this is the correct solution or not. > > - Patch #2 has grown a little since the first version I posted, I > found a few extra callbacks which can be marked as noexcept. > > - Patch #3 is new, this adds the noexcept keyword to the typedefs > used to handle the libopcode callbacks, but only when we compile > for C++17 or later. > > --- > > Andrew Burgess (3): > gdb/python: avoid throwing an exception over libopcodes code > gdb/disasm: mark functions passed to the disassembler noexcept > gdb: mark disassembler function callback types as noexcept > Hi, I ran into the same problem on powerpc64le, applied the patch series and rebuild gdb, reran the test-case gdb.python/py-disasm.exp and it passes now. Thanks, - Tom > gdb/disasm-selftests.c | 5 ++- > gdb/disasm.c | 25 ++++++------ > gdb/disasm.h | 48 ++++++++++++++++------ > gdb/guile/scm-disasm.c | 2 +- > gdb/python/py-disasm.c | 91 ++++++++++++++++++++++++++++++++---------- > 5 files changed, 121 insertions(+), 50 deletions(-) > > > base-commit: f9f88aede3bb84efd088a59a5f6bccb3a6bb6516