From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id 7F022385842C for ; Wed, 8 Feb 2023 17:55:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F022385842C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id y1so17624468wru.2 for ; Wed, 08 Feb 2023 09:55:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+/NPFJAf9716g+TN5PKisZOuUAPdu4Qr3vK4oKdNOo4=; b=sNco8q0DAjUcJl27sNlhieq3KPhKfgM2qPdVH9tG/5638nCF2cSrV9uEnRBOZw1yqX 0RFgttG3qqsenXlm51ISPWlwqj+bfV0AhsRKWs/CWmEkICDzq36z8c/j6Ep6m/QnEZ7W GdkG9s+G8rNIUnWb6qkkBQXBo9MEFLrjKC65mLsq6H3UxWQRR4mQOe/VEoEXIVa8koD6 MnufduWVIgwNFxh7TXKKG+KIMwn1EInDqjlZindZpL+NvYOrTEeEaKE37CNILd8QPcRU 11fFKhxJdQXveX/PyygK2BO5wqBbBUNFr2TMDNoxkUD+tWqIMTuPLnCZB1Cp+3Wylygr DrUQ== X-Gm-Message-State: AO0yUKVvB0lpeFrd5biZhhTc+bJ+F0W5bQbpu/gXlE/fYY8I+1uHw4fU lHajuvpOxe2j565bdE4Roo1NaX0JXkJJJQ== X-Google-Smtp-Source: AK7set8XBwwpVkVgB3w8KvzxiMF1z2tGa7MmoNmNc559nu5QR40s1RMVsD87+lj9KQF/714yydz13A== X-Received: by 2002:adf:cd90:0:b0:2bf:f2f2:7d64 with SMTP id q16-20020adfcd90000000b002bff2f27d64mr8023798wrj.33.1675878917183; Wed, 08 Feb 2023 09:55:17 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id n9-20020a5d5989000000b002bc7fcf08ddsm14733767wri.103.2023.02.08.09.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 09:55:16 -0800 (PST) Subject: Re: [PATCH 3/3] gdb: don't use the global thread-id in the saved breakpoints file To: Andrew Burgess , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <22df7afc-cf88-d260-516d-7b9a45e2ad78@palves.net> Date: Wed, 8 Feb 2023 17:55:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-08 3:23 p.m., Andrew Burgess via Gdb-patches wrote: > breakpoint::print_recreate_thread (struct ui_file *fp) const > { > if (thread != -1) > - gdb_printf (fp, " thread %d", thread); > + { > + struct thread_info *thr = find_thread_global_id (thread); > + gdb_printf (fp, " thread %s", print_thread_id (thr)); print_thread_id only prints the inferior-qualified thread id if there are multiple inferiors. I am wondering whether the save breakpoints file should _always_ end up with inferior-qualified thread ids, so that reloading the saved file works the same if you meanwhile add another inferior. Otherwise, Approved-By: Pedro Alves