From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by sourceware.org (Postfix) with ESMTPS id EEE5E384F488 for ; Tue, 28 Feb 2023 11:31:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEE5E384F488 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677583878; x=1709119878; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=fyNqacqFnTqZY1pFJBIDqiCIzDAhK5ZoF50pUIJAmRA=; b=Cuv6H3KULiMB401swR3MxFDmB8ZXX1OcqIhjuhgxpBDlQMU1mfGh+J75 KmmwUfAx0vnkISjudZkEC+gxIRYwBkxPypjRQ6aXZUlXVE0KZhS2P8uAi 1/sh2YpEfOhdpEq7k1JUTwEY2SOxpdfk1AYfGZEP6dWf3Y9WC94C81rk8 TI7AKHGHo5qzlU7iWdEYIbPGKW6JuE0W7MESpjHFMLHnSPxW5mygJ0h21 qjJBL1UZ+bXmwM80Q+eRIL12ooiEFw5qeRzBqnwwDnovZRRIqk73o2XsZ u8HBoE6oqfnYiR1RvVgQK0lYOWCkDX4dmo3q4iSMoaC8XQu1SDQ56yMig Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="336401770" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="336401770" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:31:17 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="817058311" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="817058311" Received: from ultl2604.iul.intel.com (HELO localhost) ([172.28.48.47]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:31:16 -0800 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Subject: [PATCH 24/26] gdbserver: return tracked register status in regcache_raw_read_unsigned Date: Tue, 28 Feb 2023 12:28:22 +0100 Message-Id: <232ee024f5b957a07c047c724d7065074da1ef34.1677582745.git.tankut.baris.aktemur@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In regcache_raw_read_unsigned, we unconditionally return REG_VALID as the register status. This does not seem right, since the register may in fact be in another state, such as REG_UNAVAILABLE. Return the tracked status. --- gdbserver/regcache.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index 32f0e1109e6..4533e9e9b12 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -451,7 +451,7 @@ regcache_raw_read_unsigned (struct regcache *regcache, int regnum, *val = 0; collect_register (regcache, regnum, val); - return REG_VALID; + return regcache->get_register_status (regnum); } #ifndef IN_PROCESS_AGENT -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928